[checkmk-commits] [tribe29/checkmk] a84e8b: RRD columns refactor

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: a84e8bd27287ed1992fd627a1308c3f7b09fc42b https://github.com/tribe29/checkmk/commit/a84e8bd27287ed1992fd627a1308c3f7b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/metrics/rrd_fetch.py Log Message: ----------- RRD columns refactor Change-Id: I1d246efd5123682093c973432e7375f0a6d1f9c6 Commit: 8e4f95c8ee558c90de881b766cf2224d2a152848 https://github.com/tribe29/checkmk/commit/8e4f95c8ee558c90de881b766cf2224d2… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/dashboard/utils.py M tests/unit/cmk/gui/test_pages.py M web/htdocs/js/modules/figures/cmk_gauge.js Log Message: ----------- DRAFT Remove data generator class for dashlet Currently dashlets query an ajax endpoint, which is just a page, that replies to the dashlet data generator. These data generators come in a pair match to dashlet and thus become to rigid to serve multiple dashlets that only require a subset of the data or worse that can incompatible render attributes. Inspecting the ABCDatagenerator the only relevant method is generate_response_from_request. Within it, it was already capable to find the dashlet being draw, yet it extracted the configuration valuespec out of itself(DataGenerator) instead of the Dashlet, which is the correct candidate to know the required configuration valuespec. This refactoring taking as example the Single metric source, that can be displayed as a Gauge(w/o history) or Single Graph(w/o history) for a specific host and service or a Barplot with current value for multiple hosts. All configuration valuespec is transferred to the dashlets. Datagenerator is removed leaving some middle ware not to break other dashlets. And the WEB API ajax endpoint is named for single metric, but could easily process all new figure dashlets, because the dashlet type is recognized during processing not on API endpoint. The specificity of the configuration valuespec at the dashlet level allows for flexible and unique dashlet endpoint and correct data validation. Change-Id: I15b8561f1011a44f09348cfb3005af715ca484ea Commit: be661b2d4278e23bd04220b301e0ca98b1881873 https://github.com/tribe29/checkmk/commit/be661b2d4278e23bd04220b301e0ca98b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/utils.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Dashlet scatterplot: migrate vs_parameters to dashlet As proposed in previous draft. Dashlets need to keep the ownership of their parameters. Data generators only process Request on backend. No need for special page per dashlet. Change-Id: I9ededa2a9d37182d9dbb4cd4753710e190fad7b4 Commit: 7f33a572d919b77d67cfd45f91c863123caed484 https://github.com/tribe29/checkmk/commit/7f33a572d919b77d67cfd45f91c863123… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/alert_statistics.py M cmk/gui/plugins/dashboard/site_overview.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Dashlets: Site Overview & Alert statistics transfer vs Change-Id: I68df2bb3739fdf708ddbe812877d045f2c6abe30 Commit: c6a5a3996aa195fe79b7eebab66afa06448c59d3 https://github.com/tribe29/checkmk/commit/c6a5a3996aa195fe79b7eebab66afa064… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M agents/wnx/src/common/mailslot_transport.h M agents/wnx/src/common/wtools.cpp M agents/wnx/src/engine/carrier.cpp A agents/wnx/watest/readme.md M agents/wnx/watest/watest.cpp Log Message: ----------- [CMK-6971] - add manual testing ability to check slot admin protection - add run_admin_mailslot, run_standard_mailslot, test_mailslot command line parameters for watest - add short readme to keep info about watest above mentioned commands - verify manually using command line - verify mailslot access using process explorer - minor refactoring char* -> string_view Change-Id: If207febfe040bab463307d7335b5eee54cc2638a Commit: cd432d0997c1da4a0d1dcf9cbe86f55db20835b6 https://github.com/tribe29/checkmk/commit/cd432d0997c1da4a0d1dcf9cbe86f55db… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M checks/rds_licenses Log Message: ----------- Check rds_licenses support Windows Server 2019 Change-Id: I191e4350b86abe1881573a399489585362311c31 Compare: https://github.com/tribe29/checkmk/compare/327dc509e915...cd432d0997c1