[checkmk-commits] Check_MK Git: check_mk: Fix ping_levels computation of rta

Module: check_mk Branch: master Commit: 993ed1418a5bbf641e1f871ddf69c92ab1b51abb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=993ed1418a5bbf… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Dec 6 10:37:16 2011 +0100 Fix ping_levels computation of rta rta was without any effect --- .bugs/476 | 13 +++++++++++++ .bugs/477 | 11 +++++++++++ modules/check_mk.py | 2 +- 3 files changed, 25 insertions(+), 1 deletions(-) diff --git a/.bugs/476 b/.bugs/476 new file mode 100644 index 0000000..1e88e12 --- /dev/null +++ b/.bugs/476 @@ -0,0 +1,13 @@ +Title: mounts Checks should only check ro flag +Component: checks +Benefit: 1 +State: open +Cost: 1 +Date: 2011-12-06 08:52:27 +Targetversion: 1.2.0 +Class: bug + +Currently on my laptop the mounts check is flapping around because +the kernel seems to add a mount option with "commit" and change +it all the time. Basically we'd need to just monitor the ro +status. diff --git a/.bugs/477 b/.bugs/477 new file mode 100644 index 0000000..ecfe2c4 --- /dev/null +++ b/.bugs/477 @@ -0,0 +1,11 @@ +Title: main.mk Variables in Man-Page +Component: docu +Benefit: 2 +State: open +Cost: 2 +Date: 2011-12-06 09:41:11 +Targetversion: future +Class: feature + +We could generate a man-Page from the nowiki-page about +the configuration variables for main.mk and for multisite.mk diff --git a/modules/check_mk.py b/modules/check_mk.py index f884537..609b1e5 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -1187,7 +1187,7 @@ def check_icmp_arguments(hostname): elif key == "packets": args.append("-n %d" % value) elif key == "rta": - rtas = value + rta = value elif key == "loss": loss = value args.append("-w %.2f,%.2f%%" % (rta[0], loss[0]))