[checkmk-commits] Fixed globals() hack related bug

Module: check_mk Branch: master Commit: 7c71d2a86c0b045cecf9ec65c06fde1042ce2be3 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7c71d2a86c0b04… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 29 23:09:51 2019 +0100 Fixed globals() hack related bug Change-Id: I18560971ddaa33f44b8a0c8fdd4deef84341eeee --- cmk/gui/watolib/host_attributes.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/cmk/gui/watolib/host_attributes.py b/cmk/gui/watolib/host_attributes.py index 0a28548..5c5b49f 100644 --- a/cmk/gui/watolib/host_attributes.py +++ b/cmk/gui/watolib/host_attributes.py @@ -34,6 +34,7 @@ from cmk.gui.globals import html from cmk.gui.i18n import _, _u from cmk.gui.exceptions import MKUserError from cmk.gui.valuespec import ( + TextAscii, DualListChoice, Checkbox, DropdownChoice, @@ -202,7 +203,10 @@ def _declare_host_tag_attributes(): def declare_custom_host_attrs(): for attr in config.wato_host_attrs: - vs = globals()[attr['type']](title=attr['title'], help=attr['help']) + if attr['type'] == "TextAscii": + vs = TextAscii(title=attr['title'], help=attr['help']) + else: + raise NotImplementedError() if attr['add_custom_macro']: a = NagiosValueSpecAttribute(attr["name"], "_" + attr["name"], vs)