22 Jul
2019
22 Jul
'19
8:20 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 9f615a5569df35b37d8ed460d8647f4519d3ef56
https://github.com/tribe29/checkmk/commit/9f615a5569df35b37d8ed460d8647f451…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-22 (Mon, 22 Jul 2019)
Changed paths:
M cmk/gui/valuespec.py
Log Message:
-----------
Minor cleanups
Change-Id: I1bc11e93b881a37b32331d87be617f0b3b889bbd
Commit: 5343f35dde58783323652058ea045257cdaf1095
https://github.com/tribe29/checkmk/commit/5343f35dde58783323652058ea045257c…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-22 (Mon, 22 Jul 2019)
Changed paths:
M cmk/gui/valuespec.py
Log Message:
-----------
ListOfMultiple: Extract row rendering logic
Change-Id: I83303f203e9fc2091a0f5695e0f7dd6ec13db03e
Commit: 5374c9e5580dc1df07401e50028e29b5a9881401
https://github.com/tribe29/checkmk/commit/5374c9e5580dc1df07401e50028e29b5a…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-07-22 (Mon, 22 Jul 2019)
Changed paths:
M cmk/gui/plugins/wato/utils/__init__.py
M cmk/gui/valuespec.py
M cmk/gui/visuals.py
M tests/unit/cmk/gui/test_pages.py
M web/htdocs/js/modules/valuespecs.js
M web/htdocs/themes/classic/scss/_views.scss
M web/htdocs/themes/facelift/scss/_views.scss
Log Message:
-----------
ListOfMultiple: Choices are now fetched via AJAX on demand
The ListOfMultiple valuespec is currently used in two places (the filter
selection of the view editor and the tag selection of the rule condition
editor).
Instead of precomputing all the possible values, the valuespec is now
only rendering the initially selected choices. In the moment the user
adds a new choice, this will be fetched from the server using an AJAX
call.
Each call site of the ListOfMultiple valuespec needs to implement an
AJAX page which is based on ABCPageListOfMultipleGetChoice.
Change-Id: I42e83b7f009e629f2455b1cbfef18b314f3debc5
Compare: https://github.com/tribe29/checkmk/compare/13c9b7bdc8dd...5374c9e5580d