[checkmk-commits] [tribe29/checkmk] 2e2e2e: Extract common to SNMP and Agent

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2e2e2e35e346362e53da485ff6b612c4510ec52f https://github.com/tribe29/checkmk/commit/2e2e2e35e346362e53da485ff6b612c45… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-14 (Mon, 14 Dec 2020) Changed paths: M cmk/base/checkers/agent.py M cmk/base/checkers/snmp.py M cmk/fetchers/host_sections.py Log Message: ----------- Extract common to SNMP and Agent This reduces the code duplication. Note that the code should *not* be in HostSections. Actually, most methods if not every method of HostSections should be in the Parser and HostSections should only contain Final data. This way, the parsing would not be split between the parser and HostSections. Then, we could instantiate HostSections with useful data instead of whatever is currently available and modify the content of the class before finally returning it. This, however, requires larger changes to the parsers. CMK-6516 Change-Id: Ia2d37d097773dd65817762e33315c31830d3527b Commit: 2fa802b961e4447bc947626bd0d226ba454eceb9 https://github.com/tribe29/checkmk/commit/2fa802b961e4447bc947626bd0d226ba4… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-12-14 (Mon, 14 Dec 2020) Changed paths: M cmk/base/checkers/agent.py M cmk/base/checkers/snmp.py M cmk/fetchers/cache.py M cmk/fetchers/host_sections.py R tests/unit/cmk/base/checkers/test_host_sections.py A tests/unit/cmk/base/checkers/test_section_broker.py M tests/unit/cmk/fetchers/test_cache.py A tests/unit/cmk/fetchers/test_host_sections.py Log Message: ----------- Inline `update_and_store` The method was doing too much on the class: updating its argument and the itself. The algorithm is clearer inline. It is also more flexible in that the `filter()` method with faulty logic is now exposed to the caller and therefore easier to remove or fix. Also rename `../base/../test_host_sections.py` to avoid name conflicts. CMK-6516 Change-Id: I04559e32c21eabb325832766ccdb96d527eb2eec Compare: https://github.com/tribe29/checkmk/compare/c33221e61185...2fa802b961e4