12 Aug
2019
12 Aug
'19
9:40 a.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 533da33bb4fb0d2f161a1712808b86783a1c9c00
https://github.com/tribe29/checkmk/commit/533da33bb4fb0d2f161a1712808b86783…
Author: Sven Panne <sven.panne(a)tribe29.com>
Date: 2019-08-12 (Mon, 12 Aug 2019)
Changed paths:
M cmk/gui/logwatch.py
M cmk/gui/metrics.py
M cmk/gui/plugins/sidebar/master_control.py
M cmk/gui/plugins/sidebar/site_status.py
M cmk/gui/sites.py
M cmk/gui/wato/pages/sites.py
M cmk/gui/wato/user_profile.py
M cmk/gui/watolib/activate_changes.py
Log Message:
-----------
Simplify sites API.
The sites module was an example of the "swiss army knife" anti-pattern
(https://sourcemaking.com/antipatterns/swiss-army-knife), throwing together
lots of stuff which doesn't really belong together.
* Inlined a helper which didn't exceed the Fairbairn threshold.
* Inlined a few related functions which were only used once. The resulting
code is actually much more readable than before.
Now we are left with a tiny API plus only one function which doesn't belong
there (to be tackled in another commit).
Change-Id: I1edcc9c3f88b5ab01f959f8613df864a004313ee