4 Nov
2024
4 Nov
'24
9:10 a.m.
Branch: refs/heads/master
Home: https://github.com/Checkmk/checkmk
Commit: bc01d97a5ddfd246f91951950d217724b85e6e77
https://github.com/Checkmk/checkmk/commit/bc01d97a5ddfd246f91951950d217724b…
Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com>
Date: 2024-11-04 (Mon, 04 Nov 2024)
Changed paths:
M cmk/gui/rulespec.py
M cmk/gui/utils/rule_specs/legacy_converter.py
Log Message:
-----------
Prepare import cycle fix: notif param registry>watolib
The legacy converter accesses wato for numerous legacy wato groups.
It itself is accessed by the notification_parameter_registry which is
accessed by the rest api.
This commit is step one from stopping watolib from importing wato at
import time.
The fix is suboptimal though might be acceptable as the legacy converter
can soon be removed and the alternative would be a major refactoring to
pull out the wato groups out of wato.
CMK-19751
Change-Id: Ia0e2a2661ae204790a570872a99737e45258f8b0
Commit: d50dca1fef38ef501fdc6c135af247792d243946
https://github.com/Checkmk/checkmk/commit/d50dca1fef38ef501fdc6c135af247792…
Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com>
Date: 2024-11-04 (Mon, 04 Nov 2024)
Changed paths:
M cmk/gui/cre/registration.py
M cmk/gui/mkeventd/registration.py
M cmk/gui/mkeventd/wato.py
M cmk/gui/openapi/endpoints/notification_rules/request_schemas.py
M cmk/gui/wato/__init__.py
M cmk/gui/wato/_notification_parameter/__init__.py
R cmk/gui/wato/_notification_parameter/_base.py
M cmk/gui/wato/_notification_parameter/_cisco_webex_teams.py
M cmk/gui/wato/_notification_parameter/_ilert.py
M cmk/gui/wato/_notification_parameter/_jira_issues.py
M cmk/gui/wato/_notification_parameter/_mail.py
M cmk/gui/wato/_notification_parameter/_ms_teams.py
M cmk/gui/wato/_notification_parameter/_opsgenie_issues.py
M cmk/gui/wato/_notification_parameter/_pagerduty.py
M cmk/gui/wato/_notification_parameter/_pushover.py
R cmk/gui/wato/_notification_parameter/_registry.py
M cmk/gui/wato/_notification_parameter/_servicenow.py
M cmk/gui/wato/_notification_parameter/_signl4.py
M cmk/gui/wato/_notification_parameter/_slack.py
M cmk/gui/wato/_notification_parameter/_sms_api.py
M cmk/gui/wato/_notification_parameter/_spectrum.py
M cmk/gui/wato/_notification_parameter/_victorops.py
M cmk/gui/wato/_notification_parameter/registration.py
M cmk/gui/wato/_notification_settings.py
M cmk/gui/wato/_pre_21_plugin_api.py
M cmk/gui/wato/pages/notifications/modes.py
M cmk/gui/wato/registration.py
M cmk/gui/watolib/configuration_entity/configuration_entity.py
R cmk/gui/watolib/notification_parameter.py
A cmk/gui/watolib/notification_parameter/__init__.py
A cmk/gui/watolib/notification_parameter/_base.py
A cmk/gui/watolib/notification_parameter/_registry.py
A cmk/gui/watolib/notification_parameter/_utils.py
M tests/unit/cmk/gui/openapi/test_notification_rules.py
M tests/unit/cmk/gui/openapi/test_openapi_configuration_entity.py
R tests/unit/cmk/gui/wato/test_notification_parameters.py
A tests/unit/cmk/gui/watolib/notification_parameter/test_registry.py
A tests/unit/cmk/gui/watolib/notification_parameter/test_utils.py
R tests/unit/cmk/gui/watolib/test_notification_parameter.py
Log Message:
-----------
Fix import cycle restapi->watolib->wato->watolib
We pull the notification_registry from wato into watolib.
We don't move registrations or notification parameter sets
CMK-19751
Change-Id: I5bfb7481007273b8919380e01bea053cc2c3ccd5
Compare: https://github.com/Checkmk/checkmk/compare/c2654f2592e1...d50dca1fef38
To unsubscribe from these emails, change your notification settings at
https://github.com/Checkmk/checkmk/settings/notifications