[checkmk-commits] [Checkmk/checkmk] bdec52: ovs_bonding: improve test coverage for parser

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: bdec52c0f349cd232981dd2c32c25d60d29fb860 https://github.com/Checkmk/checkmk/commit/bdec52c0f349cd232981dd2c32c25d60d… Author: Logan Connolly <logan.connolly(a)checkmk.com> Date: 2024-09-05 (Thu, 05 Sep 2024) Changed paths: M tests/unit/cmk/plugins/collection/agent_based/test_ovs_bonding.py Log Message: ----------- ovs_bonding: improve test coverage for parser The parse function does not handle errors explicitly. By adding test coverage to uncaught exceptions, it makes it easier to refactor. Change-Id: Iee4ac9b4cc6ffd20e4e140a578ca250fd1099fc7 Commit: 8d38af419438daeffea79a16c60bef436073599d https://github.com/Checkmk/checkmk/commit/8d38af419438daeffea79a16c60bef436… Author: Logan Connolly <logan.connolly(a)checkmk.com> Date: 2024-09-05 (Thu, 05 Sep 2024) Changed paths: M cmk/plugins/collection/agent_based/ovs_bonding.py M tests/unit/cmk/plugins/collection/agent_based/test_ovs_bonding.py Log Message: ----------- ovs_bonding: refactor and fix diagnostic errors Pyright diagnostic errors: - "bond" is possibly unbound (reportPossiblyUnboundVariable) - "last_interface" is possibly unbound (reportPossiblyUnboundVariable) - Could not access item in TypedDict "status" is not a required key in "Interface", so access may result in runtime exception (reportTypedDictNotRequiredAccess) For the unbound variables, we are now raising a meaningful error when the string table is in an unexpected state. The parsing function also now handles the case when "status" key is missing. Change-Id: Iad994190de745e8020b81e0f2de17518bb9f6784 Compare: https://github.com/Checkmk/checkmk/compare/11f5e0650600...8d38af419438 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications