[checkmk-commits] [tribe29/checkmk] f599ba: Fix service discovery display toggles

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f599ba68e7cc4db99051b3edf39db17c114feae9 https://github.com/tribe29/checkmk/commit/f599ba68e7cc4db99051b3edf39db17c1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-02 (Wed, 02 Sep 2020) Changed paths: M cmk/gui/wato/pages/services.py M web/htdocs/js/modules/service_discovery.js Log Message: ----------- Fix service discovery display toggles We previously tried to render the page menu once and then update single elements of the page menu during the subsequent page updates. This did not work well and was error prone. We now re-render the whole page menu, just like we do it with the page content. This consistent handling of both page elements centralizes the logic in the Python code which makes it easier to understand and maintain. This commit adds the new behaviour. Following commits will simplify the toggle elements and remove the old update logic. Change-Id: I1dc789c9e22b36c0cac59e908b9b97bb808416c0 Commit: 52d2ff770a216a1b805c4ebc827fac1185023067 https://github.com/tribe29/checkmk/commit/52d2ff770a216a1b805c4ebc827fac118… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-02 (Wed, 02 Sep 2020) Changed paths: M cmk/gui/page_menu.py M cmk/gui/wato/pages/services.py Log Message: ----------- Use standard PageMenuCheckbox element for discovery toggles To be consistent with other page menus that have toggles, we use the standard toggle elements. Change-Id: I49623d89801f6da19aa7c0798f3b39d0f12ad77b Commit: 073889a4370ca8a27bbc85062823811f6a30b2e7 https://github.com/tribe29/checkmk/commit/073889a4370ca8a27bbc85062823811f6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-02 (Wed, 02 Sep 2020) Changed paths: M cmk/gui/wato/pages/services.py M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Unbreak service discovery checkbox styling Change-Id: I0636946f864f53fddc94f49732d8be3247a1cfd1 Commit: e5f3838dd7a5d8499add1d25cf7869d2cce186ec https://github.com/tribe29/checkmk/commit/e5f3838dd7a5d8499add1d25cf7869d2c… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-02 (Wed, 02 Sep 2020) Changed paths: M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Drop dead style Change-Id: Ic44672610b1035c2cdf4a70045026dca3be78fc3 Compare: https://github.com/tribe29/checkmk/compare/b3f5ed2bcfa7...e5f3838dd7a5