[checkmk-commits] [Checkmk/checkmk] 7b7c96: Do not overwrite existing types

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 7b7c96d577fa8740b591fa4d994fda37aad76dab https://github.com/Checkmk/checkmk/commit/7b7c96d577fa8740b591fa4d994fda37a… Author: Benedikt Seidl <benedikt.seidl(a)checkmk.com> Date: 2024-06-06 (Thu, 06 Jun 2024) Changed paths: M packages/cmk-frontend/package-lock.json M packages/cmk-frontend/package.json M packages/cmk-frontend/src/js/modules/nodevis/example_generator.ts M packages/cmk-frontend/src/js/modules/nodevis/type_defs.ts Log Message: ----------- Do not overwrite existing types * previous versions of d3.HierarchyNode did not have a type definition for x and y at all. * we added a type definition for the type and defined x and y as `number`. This worked because the new and old type definitions were compatible. * type library got an update ans also added the type for x and y, but they added `number | undefined` as type * typescript now found two different type definitions for the same attribute, and threw an error: `TS2687: All declarations of 'x' must have identical modifiers.` We now declare a new local type definition and cast the official d3.HierarchyNode to our extended, internal one at some critical places. CMK-17220 Change-Id: Ifd569a87d8f569a755e5373b2d29460ee75e9090 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications