[checkmk-commits] [tribe29/checkmk] 2bb7a5: FileCache: Collapse booleans #1

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2bb7a520b31c2b1b219db571c7d4fe99b0af8766 https://github.com/tribe29/checkmk/commit/2bb7a520b31c2b1b219db571c7d4fe99b… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M cmk/base/sources/piggyback.py M cmk/core_helpers/agent.py M cmk/core_helpers/cache.py M cmk/core_helpers/piggyback.py M cmk/core_helpers/snmp.py M tests/unit/cmk/base/sources/test_cmd_caching.py M tests/unit/cmk/base/sources/test_tcp_data_source.py M tests/unit/cmk/core_helpers/test_fetchers.py Log Message: ----------- FileCache: Collapse booleans #1 The behavior of the class is controlled with many booleans and inheritance, some of it is redundant. Replacing the booleans with other types let's us simplify our code. CMK-10578 Change-Id: Id3cae23e0adaf0986eed5692d28dceae97b4399a Commit: 20b1213bd082b62b63144fdc6c1af35dc6e16116 https://github.com/tribe29/checkmk/commit/20b1213bd082b62b63144fdc6c1af35dc… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M cmk/core_helpers/agent.py M cmk/core_helpers/cache.py M cmk/core_helpers/snmp.py Log Message: ----------- FileCache: Collapse booleans #2 Remove case where the attribute `use_outdated` could be False but the FileCache would override the setting using a non-obviously related attribute. This further aims at more clearly separating configuration and business logic. The business logic should drive the configuration but the FileCache instances should not need to contribute to the BL but either read the data from a file, or not. CMK-10578 Change-Id: I905d97c4a2b9ecceccc20acbb26b72f62ce1763a Commit: 5f17a229a7d7cc5eac4cf8907f7e949fc7ad26e1 https://github.com/tribe29/checkmk/commit/5f17a229a7d7cc5eac4cf8907f7e949fc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M tests/unit/cmk/gui/plugins/openapi/test_openapi_service_discovery.py Log Message: ----------- Try to improve flaky test Seems the background job can finish pretty quickly to already return a "is finish" response right in the first response after triggering it. Change-Id: I1b7db20be07c259b5483cb406f1dc6bc49fa5bbd Compare: https://github.com/tribe29/checkmk/compare/6aed1a377e24...5f17a229a7d7