19 Nov
2019
19 Nov
'19
3:31 a.m.
Branch: refs/heads/1.6.0
Home: https://github.com/tribe29/checkmk
Commit: 982c7941be335d3b8986200306cb2ab2c9a69a6f
https://github.com/tribe29/checkmk/commit/982c7941be335d3b8986200306cb2ab2c…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
A .werks/10385
M docker/Dockerfile
M docker/Makefile
M tests/docker/test_docker.py
M tests/testlib/__init__.py
Log Message:
-----------
10385 FIX Do not expose download credentials to the image history
The previous "docker build" mechanism was using docker build arguments for
handing over the Checkmk enterprise download credentials to the docker image
build procedure. This was making the credentials available in the meta
information of the docker image, which may not be acceptable in many
situations.
If you simply want to use the Checkmk docker container, you don't need to care
about the details below. This is just relevant for the ones building own docker
images with Checkmk using the standard build logic.
This change switches the image build logic to use a small busybox based
container during image building that manages the secret download
credentials and provides it to the "docker build" command. These will
either be stopped and removed after the build finished successfully or
after 180 seconds.
If you build images on your own, you don't have to change anything if
you use our build logic (docker/Makefile).
Change-Id: I67de6a0f2f7e0196bc7d1c3d2bcabdaf43e28a46
Commit: 131f2fd83b82c698763e235d70be18bcf692d638
https://github.com/tribe29/checkmk/commit/131f2fd83b82c698763e235d70be18bcf…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
M checks/check_http
M tests/unit/checks/test_check_http.py
Log Message:
-----------
check_http: don't use the -H option when a proxy is used
In the proxy case the hostname is not set via the -H option,
but given as the second positional argument. If -H is given
anyway the second positional argument will override it. To
make the use of the second positional argument more explicit
we now omit the -H option entirely in this case.
Add a test case along the way.
CMK-3184
Change-Id: Ib241d2beb4fe979cd8b054fab2d927f35ac03332
Commit: 25631e489720dc58b39331621a1595ce1a3d69a3
https://github.com/tribe29/checkmk/commit/25631e489720dc58b39331621a1595ce1…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
M checks/check_http
M tests/unit/checks/test_check_http.py
Log Message:
-----------
check_http: always use the second positional argument to set the hostname
The hostname can be set either with the -H option or via the
second positional argument. We now use the second argument
exclusively to set the hostname.
CMK-3184
Change-Id: Ia8885519b2d460740c7fcfd3d26c285cb171eeb3
Commit: 12f11044038588f8cab6b4839107f947a6edd356
https://github.com/tribe29/checkmk/commit/12f11044038588f8cab6b4839107f947a…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
M checks/check_http
Log Message:
-----------
check_http: simplify logic to determine host name and server address
CMK-3184
Change-Id: I8df04470cbf9a01fcd8e6a33e8e75f7625128ce2
Commit: d66f3940887f7b96a9f008d12af5b92a9acb2f57
https://github.com/tribe29/checkmk/commit/d66f3940887f7b96a9f008d12af5b92a9…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
M checks/check_http
Log Message:
-----------
check_http: don't alias host.address and host.virtual
CMK-3184
Change-Id: I7c9f70f5f238e4ed32d9792c02bba0c0bb782cb2
Commit: 21104c8ecdf5f8220c1ad5834aaa170f6e92c9cc
https://github.com/tribe29/checkmk/commit/21104c8ecdf5f8220c1ad5834aaa170f6…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2019-11-19 (Tue, 19 Nov 2019)
Changed paths:
A .werks/10451
M checks/check_http
M cmk/gui/plugins/wato/active_checks.py
M tests/unit/checks/test_check_http.py
Log Message:
-----------
10451 FIX check_http: don't set virtual host if not necessary
Since version 1.6 the active check check_http automatically
set the HTTP Host header and used HTTP/1.1 instead of HTTP/1.0
even if no virtual host was supplied. This may lead to
timeouts of the check_http plugin on servers which are not
fully compliant with HTTP/1.1.
This werk changes this behaviour so that the Host header is
only set if a virtual host is given.
Please note that if you rely on HTTP/1.1 or want to use it you
have to supply a virtual host.
Please also note that the virtual host will not be set
automatically to the host name anymore. If you relied on this
behaviour you now have to provide the virtual host in the
affected rules.
CMK-3184
Change-Id: I82c1936acc4d4cba8265b21f6a5b587e9823c9f4
Compare: https://github.com/tribe29/checkmk/compare/5cfba5830027...21104c8ecdf5