[checkmk-commits] Check_MK Git: check_mk: #2653 FIX winperf_msx_queues: fixed incorrect cancelation of check claiming no counters were available

Module: check_mk Branch: master Commit: 08712e29f2e41c3b354f832fd4ade6adf5fcf706 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=08712e29f2e41c… Author: Sebastian Herbord &lt;sh(a)mathias-kettner.de&gt; Date: Tue Sep 29 16:03:45 2015 +0200 #2653 FIX winperf_msx_queues: fixed incorrect cancelation of check claiming no counters were available In versions 1.2.6p11 and 1.2.6p12 this check would report unknown state with the message "no counters available, transport service running?" even though there were counters --- .werks/2653 | 11 +++++++++++ ChangeLog | 1 + checks/winperf_msx_queues | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/2653 b/.werks/2653 new file mode 100644 index 0000000..948face --- /dev/null +++ b/.werks/2653 @@ -0,0 +1,11 @@ +Title: winperf_msx_queues: fixed incorrect cancelation of check claiming no counters were available +Level: 1 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i3 +Date: 1443535176 + +In versions 1.2.6p11 and 1.2.6p12 this check would report unknown state with the message "no +counters available, transport service running?" even though there were counters diff --git a/ChangeLog b/ChangeLog index 54c4900..239b5e1 100644 --- a/ChangeLog +++ b/ChangeLog @@ -203,6 +203,7 @@ * 2609 FIX: mysql_capacity: Can now handle sizes reported being NULL... * 2627 FIX: knuerr_sensors: no longer creates a service for unnamed sensor... * 2631 FIX: janitza_umg_freq: fixed crash when no frequency measurements were reported by the device + * 2653 FIX: winperf_msx_queues: fixed incorrect cancelation of check claiming no counters were available... Multisite: * 2385 SEC: Fixed possible reflected XSS on all GUI pages where users can produce unhandled exceptions... diff --git a/checks/winperf_msx_queues b/checks/winperf_msx_queues index 3e2ba1c..53c4b1c 100644 --- a/checks/winperf_msx_queues +++ b/checks/winperf_msx_queues @@ -91,7 +91,7 @@ def inventory_winperf_msx_queues(info): def check_winperf_msx_queues(item, params, info): # current windows agents should not produce winperf sections with no data after the header but # this ensures compatibility with older agents - if len(info) < 2 or int(info[1][0]): + if len(info) < 2 or int(info[1][0]) < 1: return 3, "no counters available, transport service running?" # Old default case: