[checkmk-commits] [tribe29/checkmk] 9493f8: Simplify classes

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9493f8e0db9dd3626e5e4aa0a5ee1dd30d684d82 https://github.com/tribe29/checkmk/commit/9493f8e0db9dd3626e5e4aa0a5ee1dd30… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Simplify classes Make _build_url a simple helper function and drop the now empty base class LivestatusSearchBase. Change-Id: I28459870f0709e86eff7904033c6d52b24f450b9 Commit: 7fff9851f3fdddac4f23454d212038ab232e3e37 https://github.com/tribe29/checkmk/commit/7fff9851f3fdddac4f23454d212038ab2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Clarified result processing Instead of populating the class member self._elements, the results of the search are now passed through the call stack until they reach the method that generates HTML code for the search result. This reduces the class level state to simplify the code. Change-Id: I8187160f7897dbf94ba2221b41fb5d35d2a1460d Commit: f6975f030d5ecde8f4c4ecc4ccfa39a95ea9f18e https://github.com/tribe29/checkmk/commit/f6975f030d5ecde8f4c4ecc4ccfa39a95… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Use better data structure for results Change-Id: Ibd0e87dcda42c45a764a1e62202d17e70e2f7dfc Commit: fed3ac75a1de708e4ba46cede559ef4a3df6c767 https://github.com/tribe29/checkmk/commit/fed3ac75a1de708e4ba46cede559ef4a3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Extract result HTML rendering Move the HTML rendering of the search results to a dedicated render class. Inline two tiny helper functions into the quicksearch page handlers for a smaller call stack. Change-Id: I5c516574c35971cff6b92e2725f12e3808d7274e Commit: 1ec32e20b38157eaece4b06e41c825dcc78bc35a https://github.com/tribe29/checkmk/commit/1ec32e20b38157eaece4b06e41c825dcc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/config/base.py M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Clarify filter behaviour value Change-Id: I329ee2eab0a52bea887335fbefb99622c5d39a13 Commit: 7b0686665096ac9589d5f83768c7f8a16f659749 https://github.com/tribe29/checkmk/commit/7b0686665096ac9589d5f83768c7f8a16… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Clarified search object processing Instead of populating the class member self._search_objects, these objects are are now passed through the call stack until they produce the search result objects. This clarifies the dependencies and flow. Change-Id: I956b44d446cf771224f5cb42679b4fe2f34945d9 Commit: fa996af48a243ccf6bb159c7bd2b8e7d933ec9fc https://github.com/tribe29/checkmk/commit/fa996af48a243ccf6bb159c7bd2b8e7d9… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Generalized class name The quicksearch plugins may use livestatus, but are not tied to it. We'll have non livestatus plugins soon. Prepare for it. Add some more doc strings. Change-Id: Iaa5929740bfb0b944db023bde0a7dcd9e7e3dbcd Commit: 25eec5885d9e854212bb095a84f4c2a755ce5444 https://github.com/tribe29/checkmk/commit/25eec5885d9e854212bb095a84f4c2a75… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Add conductor base class Until now all quicksearch plugins are based on livestatus queries and may be aggregated by the LivestatusSearchConductor. Once we add the first non livestatus filter, we need to handle it in a different way. This commit prepares for introducing another type of plugin. This will then be managed by a search conductor without further aggregation. Change-Id: Ie78bb290c454f80063bac142b63ee21a9ac5d694 Compare: https://github.com/tribe29/checkmk/compare/a3cbfcfb777f...25eec5885d9e