[checkmk-commits] [tribe29/checkmk] 2338cd: Extract loop for make_host_sections

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2338cd4a37ea4d4a554a01c049224882f721c7d5 https://github.com/tribe29/checkmk/commit/2338cd4a37ea4d4a554a01c049224882f… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/base/checking.py M cmk/base/data_sources/_data_sources.py M cmk/base/discovery.py M cmk/base/inventory.py M tests/unit/cmk/base/data_sources/test_host_sections.py Log Message: ----------- Extract loop for make_host_sections Exception handling and host sections (summary) handling are done using an implicit protocol as both are cached on the Checker class. Originally, the data source class was also caching the exception from the fetcher. After the split, this is not practicable anymore as the fetcher is not in the checker anymore. Therefore, we now need to make the error handling protocol explicit. This requires some refactoring in the data source users such as inventory, discovery, or check_mk (compare 🍝). The biggest culprit here is now `make_host_sections` because it calls `fetcher.fetch()` and `checker.check()` directly and hides raw data, exception, and host sections. Unfortunately, the fact that `make_host_sections` takes an iterable makes it nearly impossible to simply rearrange the code. This patch separates the construction of the loop from the iteration on the loop. CMK-5275 Change-Id: I3139233dc67b03974f4bb99a7100d295ec02b1a8 Commit: 897bb8e470d83e4eec0bfcb69d1a6a8574c59d5b https://github.com/tribe29/checkmk/commit/897bb8e470d83e4eec0bfcb69d1a6a857… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/base/discovery.py Log Message: ----------- Minor unyapfing of discovery CMK-5275 Change-Id: I62768d020d0d32df9b037564555199dda5fe2cc5 Commit: cc6f6bfdad2f4b85ca014daac1e5d5b8f000fb4d https://github.com/tribe29/checkmk/commit/cc6f6bfdad2f4b85ca014daac1e5d5b8f… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M agents/wnx/src/common/wtools.cpp M agents/wnx/src/engine/cfg.cpp Log Message: ----------- [FEED-5122] - enable only root folder protection: programdata/checkmk use SID instead of Users group name to support internationalization Change-Id: I3bf86843af951dc1988de5ce4f82226e3c46f4b0 Compare: https://github.com/tribe29/checkmk/compare/d783f4f23593...cc6f6bfdad2f