[checkmk-commits] [tribe29/checkmk] 93a6e0: SAML valuespec: move config models to config module

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 93a6e00972dae9d79e6ba5021d12d031e03cabf5 https://github.com/tribe29/checkmk/commit/93a6e00972dae9d79e6ba5021d12d031e… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: A cmk/gui/userdb/saml2/config.py M cmk/gui/userdb/saml2/connector.py M cmk/gui/userdb/saml2/interface.py Log Message: ----------- SAML valuespec: move config models to config module This is for easier rieview of the follow-up commit. Change-Id: I54699e5bbfb2993793ce15abdd0d745d6ddfb722 Commit: d050d01e86d89e94462da60c8c39f9f5e07c1728 https://github.com/tribe29/checkmk/commit/d050d01e86d89e94462da60c8c39f9f5e… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/config.py M cmk/gui/userdb/saml2/connector.py M cmk/gui/wato/pages/saml2.py M tests/unit/cmk/gui/userdb/saml2/conftest.py A tests/unit/cmk/gui/userdb/saml2/test_config.py M tests/unit/cmk/gui/userdb/saml2/test_interface.py R tests/unit/cmk/gui/wato/pages/test_saml2.py Log Message: ----------- SAML valuespec: introduce module 'config' Rework an idea that did not turn out well in practice. Improvements: * parsing beomes a one-way street, instead of valuespec to config, config to valuespec * dedicated module 'config' responsible for valuespec parsing ** simplified tests ** additional monkeypatching in conftest is temporary and will be removed by the following commits Change-Id: I1252058a2d0395dd1f5fd5ffae749bca422c0882 Commit: d4be5e16ae4f9b1d595d718c2145a3d77eb2327f https://github.com/tribe29/checkmk/commit/d4be5e16ae4f9b1d595d718c2145a3d77… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/config.py M cmk/gui/wato/pages/saml2.py M tests/unit/cmk/gui/userdb/saml2/test_config.py Log Message: ----------- SAML: delegate config file writing to valuespec * config writing is done in just one place * valuespec transformations are more easily testable Change-Id: I36915769f7dd76c35a0f9e3884b6630d46c67876 Commit: 995f4b3d5cac4c0f5cd330cc578e6ea40575645b https://github.com/tribe29/checkmk/commit/995f4b3d5cac4c0f5cd330cc578e6ea40… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/config.py Log Message: ----------- SAML: improve config variable parsing * assign values from valuespec dict directly Change-Id: Id7db251d7fe26f618983c694141ab4806d3631fb Commit: e599a6c8cb48d0f4231f75e10de6ba4ea7bfee19 https://github.com/tribe29/checkmk/commit/e599a6c8cb48d0f4231f75e10de6ba4ea… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/config.py M cmk/gui/userdb/saml2/connector.py M cmk/gui/userdb/saml2/pages.py M tests/unit/cmk/gui/userdb/saml2/test_connector.py Log Message: ----------- SAML: decouple interface from connector * does not need to be coupled * more flexibility for changes and better testable * has the side-effect of not having to handle any errors when the UserConnector is instantiated vs when the Interface is instantiated Change-Id: Icabb5b32c3f4097cc0a88610662a8a45e859c741 Commit: 85436214e1089dc7c5d0556ca4fd81cdac1d8724 https://github.com/tribe29/checkmk/commit/85436214e1089dc7c5d0556ca4fd81cda… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M tests/unit/cmk/gui/userdb/saml2/conftest.py M tests/unit/cmk/gui/userdb/saml2/test_config.py M tests/unit/cmk/gui/userdb/saml2/test_interface.py Log Message: ----------- SAML: move interface specific fixtures to interface test module Change-Id: Ia654bb745a8c4b4f887013efba740ae975b9a14f Commit: 5353c39429c8d5f2d548db540e45756173cf0aca https://github.com/tribe29/checkmk/commit/5353c39429c8d5f2d548db540e4575617… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M tests/unit/cmk/gui/userdb/saml2/test_interface.py Log Message: ----------- SAML: interface tests: remove unnecessary fixtures * use global constants instead (already have the desired scope) * easier to follow Change-Id: I7a189db81177f25a9ddd2723b8764d8882f53f86 Commit: 13c128f5380f6cba9ebd4d6751909482e1e48512 https://github.com/tribe29/checkmk/commit/13c128f5380f6cba9ebd4d6751909482e… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2023-01-16 (Mon, 16 Jan 2023) Changed paths: M cmk/gui/userdb/saml2/config.py M cmk/gui/userdb/saml2/interface.py M tests/unit/cmk/gui/userdb/saml2/test_connector.py M tests/unit/cmk/gui/userdb/saml2/test_interface.py Log Message: ----------- SAML: keep config external to the app * config is set in one place * improved testability Change-Id: I36dbaaa68933204a9c266c7e6aefac6fbd7f7394 Compare: https://github.com/tribe29/checkmk/compare/bd0d0ee6ce97...13c128f5380f