3 Jul
2012
3 Jul
'12
noon
Module: check_mk
Branch: master
Commit: 6525c62e5ef543b5a029b8503a387e8f92f58843
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6525c62e5ef543…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Tue Jul 3 13:59:48 2012 +0200
FIX: fixed default setting if "Hide names of configuration variables"
in WATO
---
.bugs/759 | 12 ++++++++++++
.bugs/774 | 7 +++++--
ChangeLog | 2 ++
web/plugins/wato/check_mk_configuration.py | 2 +-
4 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/.bugs/759 b/.bugs/759
index bd1c060..5a35e43 100644
--- a/.bugs/759
+++ b/.bugs/759
@@ -20,3 +20,15 @@ working!
Furthermore: If you now uncheck the one single
checkbox and again issue a command: it will still
think this box is checked.
+
+----
+
+This is related to the URL parsing code in javascript.
+The "no" link destroys the url because it issues a POST
+request. We need to make the POST vars available in js
+to make this code work again. Maybe we add a general code
+which makes all variables available as json construct in JS.
+
+But this does not resolve the problem completely. Once we
+have too many vars we need to make POST requests for reloading
+views.
diff --git a/.bugs/774 b/.bugs/774
index ae43041..5a1f575 100644
--- a/.bugs/774
+++ b/.bugs/774
@@ -1,11 +1,14 @@
Title: Option "hide names of configuration variables" works only after
switching
Component: wato
-State: open
+Class: bug
+State: done
Date: 2012-06-15 13:53:06
Targetversion: 1.2.0
-Class: bug
The configuration variable is - per WATO - default off. But
in fact the real default value seems to be True. So
in order to see the variable names you need to toggle
once on and off again.
+
+2012-07-03 13:58:51: changed state open -> done
+Fixed WATO option definition
diff --git a/ChangeLog b/ChangeLog
index 2635658..a052e19 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -52,6 +52,8 @@
* FIX: massive speedup when changing roles/users and activing changes
(especially when you have a larger number of users and folders)
* Add variable CONTACTPAGER to allowed macros in notifications
+ * FIX: fixed default setting if "Hide names of configuration variables"
+ in WATO
BI:
* New iterators FOREACH_CHILD and FOREACH_PARENT
diff --git a/web/plugins/wato/check_mk_configuration.py
b/web/plugins/wato/check_mk_configuration.py
index 513fc6c..d4e5d7c 100644
--- a/web/plugins/wato/check_mk_configuration.py
+++ b/web/plugins/wato/check_mk_configuration.py
@@ -179,7 +179,7 @@ register_configvar(group,
label = _("hide variable names"),
help = _("When enabled, internal configuration variable names of
Check_MK are hidded "
"from the user (for example in the rule editor)"),
- default_value = False),
+ default_value = True),
domain = "multisite")
register_configvar(group,