[checkmk-commits] [tribe29/checkmk] 61d1ee: pages/services: inline single used methods of Mode...

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 61d1ee7c108fc11e409d430f9ed8eadf1891258d https://github.com/tribe29/checkmk/commit/61d1ee7c108fc11e409d430f9ed8eadf1… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: M cmk/gui/wato/pages/services.py Log Message: ----------- pages/services: inline single used methods of ModeAjaxServiceDiscovery Change-Id: I412e30166dbada0df46a582db4914416c1d6e98a Commit: 03b45e44f86a583a610acd3aaf2f9f12fa288dc5 https://github.com/tribe29/checkmk/commit/03b45e44f86a583a610acd3aaf2f9f12f… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: M cmk/gui/wato/pages/services.py Log Message: ----------- pages/services: remove self.options to make usages more visible Change-Id: Ie8ba5ac7e9ad16fef4d6d1153da6fbc318d5e217 Commit: 4c709697e20002b591ec79a96e40f9fb7ad91a2c https://github.com/tribe29/checkmk/commit/4c709697e20002b591ec79a96e40f9fb7… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: M cmk/gui/wato/pages/services.py Log Message: ----------- pages/services: remove self._host to make host usages more visible Change-Id: I62f8d21ef52c30a073f407c85ad0aabfdd56bacb Commit: 36883b981ef1d573f0ebe4b7c903a36b477ff6e3 https://github.com/tribe29/checkmk/commit/36883b981ef1d573f0ebe4b7c903a36b4… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/service_discovery.py M cmk/gui/wato/pages/services.py M cmk/gui/watolib/services.py Log Message: ----------- watolib/services: refactor class Discovery init to remove non relevant parameters Change-Id: I1ba420bebc64099c89f8dc7711ba36ce8effc215 Commit: d77486433f72b8e69a807cdfda561df53d7fb7d0 https://github.com/tribe29/checkmk/commit/d77486433f72b8e69a807cdfda561df53… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: M cmk/gui/wato/pages/services.py M cmk/gui/watolib/services.py Log Message: ----------- pages/services: move non-gui related discovery functionality to watolib/services Change-Id: If2e5f468c54b18dd5eab30bf937910a9e026d6c9 Commit: dbf5dc35fe6e8350f8f4b34ceac66bb785e6a76e https://github.com/tribe29/checkmk/commit/dbf5dc35fe6e8350f8f4b34ceac66bb78… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: M cmk/gui/watolib/services.py A tests/unit/cmk/gui/watolib/test_services.py Log Message: ----------- test_services: addition of tests for discovery action Change-Id: I54cf733feae87b2e631ee4a61cd821ea19328c15 Commit: b164b010a1d437142529c9da3674550ce59ad192 https://github.com/tribe29/checkmk/commit/b164b010a1d437142529c9da3674550ce… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: M cmk/gui/watolib/services.py Log Message: ----------- services: refactoring of perform discovery to make steps more visible for each action type Change-Id: Ia5380b74f0f2b2562172f6a076219cef9c71bb02 Commit: 456f2b59a113b28a7783695a6132bd2f65b8c797 https://github.com/tribe29/checkmk/commit/456f2b59a113b28a7783695a6132bd2f6… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: M cmk/gui/wato/pages/services.py M cmk/gui/watolib/services.py M tests/unit/cmk/gui/watolib/test_services.py M tests/unit/test_pipfile.py Log Message: ----------- services: separate discovery functionalities into their own functions Change-Id: I6c978173f0f6d95781e3ac9fcb02b8805af26185 Commit: f0bf1118cbf720d40c10157672d2ef2fbaa713cc https://github.com/tribe29/checkmk/commit/f0bf1118cbf720d40c10157672d2ef2fb… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: A .werks/14341 M cmk/gui/plugins/openapi/endpoints/service_discovery.py M cmk/gui/plugins/openapi/restful_objects/type_defs.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_service_discovery.py Log Message: ----------- 14341 FIX service_discovery: reimplementation of execute discovery mode endpoint Previously, only the update detection mode provided the desired result, while all other modes either had no effect or behaved differently than described. This werk reimplements the discover_services action endpoint. In addition, the descriptions of certain modes are changed to better reflect the intended action. All modes return the same response schema as before expect the refresh option. The refresh option starts a background job. The response is therefore different from the other mode responses and contains a redirect link to the current status of the running job. The job status can also be directly queried directly via the new endpoint /domain-types/service_discovery_run/{host_name} endpoint. Change-Id: I15b7ec5107d5200f33a14b4e4e7e570c155f6b3b Commit: 84912c39e73107acb5bf9df3d7a4db5f14c754da https://github.com/tribe29/checkmk/commit/84912c39e73107acb5bf9df3d7a4db5f1… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: A .werks/14537 M cmk/gui/plugins/openapi/endpoints/service_discovery.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_service_discovery.py Log Message: ----------- 14537 service_discovery: addition of new endpoint to show full service discovery result This werk introduces the new /objects/service_discovery/{host_name} endpoint which returns the latest service discovery result of a host. The response object includes the check table with all discovered services, the host labels, the vanished and new labels. The existing /domain-types/service/collections/services endpoint, which only returned the discovered services of a specific phase is deprecated and will be removed with Checkmk 2.3. Users should consider migrating the functionalities to the new endpoint. Change-Id: I302deadf92a1bbebe421edef36e9ddc4a9b76f69 Commit: c1f4c2ca066c2f5f0b1498be7ff2407c2ba1ad8d https://github.com/tribe29/checkmk/commit/c1f4c2ca066c2f5f0b1498be7ff2407c2… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-07-15 (Fri, 15 Jul 2022) Changed paths: A .werks/14538 M cmk/gui/plugins/openapi/endpoints/service_discovery.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_service_discovery.py Log Message: ----------- 14538 service_discovery: migrate execute service discovery functionality to new endpoint This werk moves the existing "Execute a service discovery on a host" functionality to the new /domain-types/service_discovery_run/actions/start/invoke endpoint. The existing /objects/host/{host_name}/actions/discover_services/invoke endpoint is itself deprecated and will be removed with Checkmk 2.3. Users should consider migrating the functionalities to the new endpoint. Change-Id: I97c5c854abaa987055025fe515fcd678c2ba50f0 Compare: https://github.com/tribe29/checkmk/compare/022af6c8f4c0...c1f4c2ca066c