[checkmk-commits] [Checkmk/checkmk] 3798e9: Don't pass shell=True

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 3798e9508f19f23be389e278f3ba5e29b1d014d1 https://github.com/Checkmk/checkmk/commit/3798e9508f19f23be389e278f3ba5e29b… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-09-24 (Tue, 24 Sep 2024) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- Don't pass shell=True It is unclear why this was added in the first place. It does appear to impact functionality. CMK-19119 Change-Id: I5b7f6474f0cff7c71f33dbdc8530f4fa28321301 Commit: ac81956be92428ce481d9839940c5caf1abd643c https://github.com/Checkmk/checkmk/commit/ac81956be92428ce481d9839940c5caf1… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-09-24 (Tue, 24 Sep 2024) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- Simplify writing a newline Additionally, replaces ``` Creating temporary filesystem /omd/sites/test_update/tmp...OK -| ATTENTION ``` With ``` Creating temporary filesystem /omd/sites/test_update/tmp...OK Executing cmk-update-config --conflict {conflic_mode} --dry-run -| ATTENTION ``` CMK-19119 Change-Id: Id3c8ddde201955cc247545ef0830f0377233defa Commit: ce766a2232cafb991ae613f3039d19f41c2dd38c https://github.com/Checkmk/checkmk/commit/ce766a2232cafb991ae613f3039d19f41… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-09-24 (Tue, 24 Sep 2024) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- More idiomatic file read Change-Id: Iaaa9430e3e3b5d9a62e40d22476ccb8967719a10 Commit: 825e422f8c82ce3923fb728d0cebc03752115aff https://github.com/Checkmk/checkmk/commit/825e422f8c82ce3923fb728d0cebc0375… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-09-24 (Tue, 24 Sep 2024) Changed paths: M omd/packages/omd/omdlib/main.py Log Message: ----------- Use contextmanager for open fd CMK-19119 Change-Id: I08d6859347dc5237ad6843173d6b4b2ba50b09a5 Commit: d6a9113eb0572521476d0b919c9ca183dd825d03 https://github.com/Checkmk/checkmk/commit/d6a9113eb0572521476d0b919c9ca183d… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-09-24 (Tue, 24 Sep 2024) Changed paths: M cmk/update_config/lib.py Log Message: ----------- Don't write ASCII control sequence unless interactive If `cmk-update-config` is called without access to an interactive terminal session, no terminal interaction should be attempted. E.g., if `cmk-update-config` is piped into a file, then no ASCII control sequence should be written. Change-Id: I83f17aa4339713ed5757648b807a91e7e2f5df57 Commit: f2f2b06881762bfe91e770a99ca8378c455d2def https://github.com/Checkmk/checkmk/commit/f2f2b06881762bfe91e770a99ca8378c4… Author: Mehran Shahidi <mehran.shahidi(a)checkmk.com> Date: 2024-09-24 (Tue, 24 Sep 2024) Changed paths: A .werks/17285.md M cmk/gui/plugins/wato/check_parameters/bonding.py M cmk/plugins/collection/agent_based/bonding.py M tests/unit/cmk/plugins/collection/agent_based/test_bonding.py Log Message: ----------- 17285 bonding: Configurable number of expected interfaces The number of expected interfaces for the bonding checks can now be configured. You can configure the lower limit of expected interfaces and the state if the actual number is lower than the expected number. SUP-19170 Change-Id: Id0ef5d8c5ad5a9521cbcc9a6bdaa08dc63f22fbd Compare: https://github.com/Checkmk/checkmk/compare/41fa634a3d57...f2f2b0688176 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications