20 Oct
2020
20 Oct
'20
8:12 a.m.
Branch: refs/heads/test_weblate2
Home: https://github.com/tribe29/checkmk
Commit: 38c682617fb34c64aa4eef96513cc3449159d09a
https://github.com/tribe29/checkmk/commit/38c682617fb34c64aa4eef96513cc3449…
Author: Lukas Lengler <lukas.lengler(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M cmk/gui/plugins/wato/check_mk_configuration.py
Log Message:
-----------
Fix GUI Crawl (removed %s)
Change-Id: Ifcfad658a7d6a48d86523b93db51e533d97c942b
Commit: 8df2d3bfe1eebfe992a949bde5a6e50ff255a41f
https://github.com/tribe29/checkmk/commit/8df2d3bfe1eebfe992a949bde5a6e50ff…
Author: Lisa Pichler <lisa.pichler(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M checks/heartbeat_crm
Log Message:
-----------
heartbeat_crm: refactored general parse function
Change-Id: Icec5b473df224bdc52d34498f1c17ed53b11a86f
Commit: e10924be3d574867b2769bf5c40c73f63785cb6c
https://github.com/tribe29/checkmk/commit/e10924be3d574867b2769bf5c40c73f63…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M cmk/base/checking.py
M cmk/fetchers/controller.py
M cmk/utils/cpu_tracking.py
M tests/unit/cmk/utils/test_cpu_tracking.py
Log Message:
-----------
cpu_tracking: name snapshot
Before, the snapshot were saved as lists of floats. We improve the type
safety and clarify the code by giving these floats names. This further
let's us add some simple arithmetic to the new Snapshot class to clarify
the call sites.
CMK-5920
Change-Id: Ie97c1863b7de5254a03c45c08cad4d8766c75c23
Commit: 7e2aaa34260027bd5f207d99b464199ae12d78fe
https://github.com/tribe29/checkmk/commit/7e2aaa34260027bd5f207d99b464199ae…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M cmk/utils/cpu_tracking.py
Log Message:
-----------
cpu_tracking: Simplify code with defaultdict
CMK-5920
Change-Id: I3ca2c49d163cc80ee97b72cde71d151969fe93dd
Commit: 21c124e18751f50d49433acc0249e96baebffb18
https://github.com/tribe29/checkmk/commit/21c124e18751f50d49433acc0249e96ba…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M cmk/utils/cpu_tracking.py
Log Message:
-----------
cpu_tracking: Use list methods
The code becomes higher level.
CMK-5920
Change-Id: I36d3f40ac2b8b939b9d38115df4c45dd8e8d2ffb
Commit: 80e4217d25e7437f01fd1f85e8590c934a0d1f89
https://github.com/tribe29/checkmk/commit/80e4217d25e7437f01fd1f85e8590c934…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M cmk/utils/_type_defs_result.py
Log Message:
-----------
Result.fold(): Add a missing resturn type
Change-Id: Iea30f6a9d2e5b8ca9c08f63090660abee3e9e41e
Commit: 2bfd986df105fdbcc388dfa9c91a96abc37f4154
https://github.com/tribe29/checkmk/commit/2bfd986df105fdbcc388dfa9c91a96abc…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M checks/tcp_conn_stats
A cmk/base/plugins/agent_based/tcp_conn_stats.py
Log Message:
-----------
tcp_conn_stats: migrate section
Change-Id: Ic91f6fcc0ec1d865c98db95a8f546642b0ab68a5
Commit: 67c23cf373c179b60cec21d54f4c5e8a898dea23
https://github.com/tribe29/checkmk/commit/67c23cf373c179b60cec21d54f4c5e8a8…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
R checks/tcp_conn_stats
M cmk/base/check_legacy_includes/tcp_connections.py
M cmk/base/plugins/agent_based/tcp_conn_stats.py
M tests/unit/checks/test_generic_legacy_conversion.py
Log Message:
-----------
tcp_conn_stats: migrate check plugin
Change-Id: Ifd33c25e4e0a38c6860e0628091feda1bbc4dd07
Commit: 92f3171e23465dcdc00185e2e027aaae00f0c9e0
https://github.com/tribe29/checkmk/commit/92f3171e23465dcdc00185e2e027aaae0…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
R checks/winperf_tcp_conn
M cmk/base/plugins/agent_based/tcp_conn_stats.py
A cmk/base/plugins/agent_based/utils/tcp_connections.py
A cmk/base/plugins/agent_based/winperf_tcp_conn.py
M cmk/update_config.py
R tests/unit/checks/generictests/datasets/winperf_tcp_conn_regression.py
M tests/unit/checks/test_generic_legacy_conversion.py
A tests/unit/cmk/base/plugins/agent_based/test_tcp_conn_stats.py
Log Message:
-----------
winperf_tcp_conn: migrate section
Change-Id: Icb861b2219929de76ccf427d80c65d7c97c647c1
Commit: 629e8e21d6fb77089c89d3dbf9df2374cbc90430
https://github.com/tribe29/checkmk/commit/629e8e21d6fb77089c89d3dbf9df2374c…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M cmk/base/plugins/agent_based/tcp_conn_stats.py
M cmk/base/plugins/agent_based/utils/tcp_connections.py
Log Message:
-----------
tcp_conn_stats: move stuff to utils
Change-Id: I602f1058605475fe4fbb11f9d9b2a73fa5fcad85
Commit: 0b3595b67f51716d00c34e154e1a7592345fc4d3
https://github.com/tribe29/checkmk/commit/0b3595b67f51716d00c34e154e1a75923…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
R checks/datapower_tcp
M cmk/base/check_legacy_includes/datapower_scan.py
R cmk/base/check_legacy_includes/tcp_connections.py
A cmk/base/plugins/agent_based/datapower_tcp.py
A cmk/base/plugins/agent_based/utils/datapower.py
M cmk/update_config.py
R tests/unit/checks/generictests/datasets/datapower_tcp_regression.py
M tests/unit/checks/test_generic_legacy_conversion.py
Log Message:
-----------
migrate datapower_tcp
Change-Id: I41489b04de5633b298a314aba86e9d1ec9a3fe31
Commit: 20f9eced862cd1cfb217d3098259bb49c4fbaf8e
https://github.com/tribe29/checkmk/commit/20f9eced862cd1cfb217d3098259bb49c…
Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com>
Date: 2020-10-19 (Mon, 19 Oct 2020)
Changed paths:
M cmk/gui/plugins/wato/check_mk_configuration.py
Log Message:
-----------
fix formatting
Change-Id: Iad62c37418dd12817af1de9731672f6ff9c7d276
Commit: 43f690ff629aabe076ad74627e2b7da30696cee1
https://github.com/tribe29/checkmk/commit/43f690ff629aabe076ad74627e2b7da30…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-10-20 (Tue, 20 Oct 2020)
Changed paths:
M tests/unit/cmk/base/checkers/test_cmd_caching.py
Log Message:
-----------
Additional inventory test improvement
One more caching test does not need to execute the plugins.
Change-Id: Iafda99392c3c567826099b74bdd1d80ec617eea3
Commit: 86516bbc4ec8d0610bdd94f2e3e745ca8a5c27cc
https://github.com/tribe29/checkmk/commit/86516bbc4ec8d0610bdd94f2e3e745ca8…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-10-20 (Tue, 20 Oct 2020)
Changed paths:
M omd/packages/omd/omdlib/contexts.py
M omd/packages/omd/omdlib/main.py
M omd/packages/omd/omdlib/utils.py
M tests/unit/cmk/base/checkers/test_agent.py
M tests/unit/cmk/fetchers/test_fetchers.py
M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py
M tests/unit/omdlib/test_omdlib_main.py
Log Message:
-----------
Replace pyfakefs calls with way faster pytest standard fixture
pyfakefs looked like a handy tool, but has important drawbacks:
The pyfakefs fixture is very resource hungy. The Patcher searches all
modules registered to sys.modules for access to IO functions and patches
them. In our test environment the pyfakefs fixture setup phase was
consuming half of the test execution time.
To improve this, we'll have to replace all possible uses of pyfakefs.
Especially the call sites that just need access to some dirctories or
files in a temporary directoy can easily be replaced with the standard
pytest tmp_path fixture.
For the other call sites, which really want to access hard coded system
wide paths, these are the OMD tests, we had to introduce some dynamic
path prefix. This allows us to replace pyfakefs also in for these tests
without having to refactor larger parts of the OMD code.
With this change we are now down to 2(!!) minutes with our whole
collection of unit test
```
time pytest -T unit tests/unit/
========================================= test session starts
=========================================
platform linux -- Python 3.8.5, pytest-6.1.1, py-1.9.0, pluggy-0.13.1
rootdir: /home/lm/git/checkmk, configfile: pytest.ini
plugins: testmon-1.0.3, mock-3.3.1, cov-2.10.1, profiling-1.7.0, pyfakefs-4.1.0,
requests-mock-1.8.0
collected 7808 items
(...)
====================== 7794 passed, 14 skipped, 35 warnings in 113.32s (0:01:53)
======================
real 1m56,275s
user 1m18,824s
sys 0m14,788s
```
Change-Id: I3d53303830ba6103035d4e293b045dd750ad978f
Commit: 5c4b05123077edcfcef35f8c0d4b49b03feb01aa
https://github.com/tribe29/checkmk/commit/5c4b05123077edcfcef35f8c0d4b49b03…
Author: Weblate Transfer job <weblate(a)checkmk.com>
Date: 2020-10-20 (Tue, 20 Oct 2020)
Changed paths:
M locale/multisite.pot
Log Message:
-----------
Updated multisite.pot
Change-Id: If105121d356f8bf4dc184d071ae61c11148f91fa
Commit: 7c282d899b14bff4ef194915d6882adc2c9ac813
https://github.com/tribe29/checkmk/commit/7c282d899b14bff4ef194915d6882adc2…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-10-20 (Tue, 20 Oct 2020)
Changed paths:
M Pipfile
M Pipfile.lock
Log Message:
-----------
Remove now unused pyfakefs
See 86516bbc4ec8d0610bdd94f2e3e745ca8a5c27cc for further information.
Change-Id: Ie602f956c91a1f17411ab4ff0710c5fb1b666ea6
Commit: 46ed8bf1396cafc6983c407dd0b6b1091e466fd6
https://github.com/tribe29/checkmk/commit/46ed8bf1396cafc6983c407dd0b6b1091…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-10-20 (Tue, 20 Oct 2020)
Changed paths:
M cmk/gui/availability.py
M cmk/gui/backup.py
M cmk/gui/bi.py
M cmk/gui/crash_reporting.py
M cmk/gui/dashboard.py
M cmk/gui/gui_background_job.py
M cmk/gui/key_mgmt.py
M cmk/gui/login.py
M cmk/gui/logwatch.py
M cmk/gui/main.py
M cmk/gui/mobile.py
M cmk/gui/notify.py
M cmk/gui/page_menu.py
M cmk/gui/pagetypes.py
M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py
M cmk/gui/plugins/dashboard/failed_notifications.py
M cmk/gui/plugins/dashboard/stats.py
Log Message:
-----------
Replace call sites of cmk.gui.htmllib.HTML.makeuri*, part 1/5
* cmk.gui.htmllib.HTML.makeuri --> cmk.gui.utils.urls.makeuri
* cmk.gui.htmllib.HTML.makeuri_contextless -->
cmk.gui.utils.urls.makeuri_contextless
CMK-5885
Change-Id: I8d6d9757381e6b966bc7c09b649e41f802b56f30
Commit: 5cfddf5bea121b531910e49ee639d457ff5e768b
https://github.com/tribe29/checkmk/commit/5cfddf5bea121b531910e49ee639d457f…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-10-20 (Tue, 20 Oct 2020)
Changed paths:
M cmk/gui/plugins/wato/background_job.py
M cmk/gui/plugins/wato/bi_config.py
M cmk/gui/plugins/wato/check_mk_configuration.py
M cmk/gui/plugins/wato/utils/base_modes.py
M cmk/gui/plugins/wato/utils/context_buttons.py
M cmk/gui/plugins/wato/utils/simple_modes.py
M cmk/gui/sidebar.py
M cmk/gui/table.py
M cmk/gui/userdb.py
M cmk/gui/valuespec.py
M cmk/gui/view_utils.py
M cmk/gui/views.py
M cmk/gui/visuals.py
M cmk/gui/wato/mkeventd.py
M cmk/gui/wato/pages/activate_changes.py
M cmk/gui/wato/pages/check_catalog.py
M cmk/gui/wato/pages/custom_attributes.py
Log Message:
-----------
Replace call sites of cmk.gui.htmllib.HTML.makeuri*, part 3/5
* cmk.gui.htmllib.HTML.makeuri --> cmk.gui.utils.urls.makeuri
* cmk.gui.htmllib.HTML.makeuri_contextless -->
cmk.gui.utils.urls.makeuri_contextless
CMK-5885
Change-Id: I8442171575112b60b3c594dba97fdbe85152a236
Commit: a4f93899e6593b56b18d3bbd8db5d1e35582d4a3
https://github.com/tribe29/checkmk/commit/a4f93899e6593b56b18d3bbd8db5d1e35…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-10-20 (Tue, 20 Oct 2020)
Changed paths:
M Pipfile
M Pipfile.lock
R checks/datapower_tcp
M checks/heartbeat_crm
R checks/tcp_conn_stats
R checks/winperf_tcp_conn
M cmk/base/check_legacy_includes/datapower_scan.py
R cmk/base/check_legacy_includes/tcp_connections.py
M cmk/base/checking.py
A cmk/base/plugins/agent_based/datapower_tcp.py
A cmk/base/plugins/agent_based/tcp_conn_stats.py
A cmk/base/plugins/agent_based/utils/datapower.py
A cmk/base/plugins/agent_based/utils/tcp_connections.py
A cmk/base/plugins/agent_based/winperf_tcp_conn.py
M cmk/fetchers/controller.py
M cmk/gui/availability.py
M cmk/gui/backup.py
M cmk/gui/bi.py
M cmk/gui/crash_reporting.py
M cmk/gui/dashboard.py
M cmk/gui/gui_background_job.py
M cmk/gui/key_mgmt.py
M cmk/gui/login.py
M cmk/gui/logwatch.py
M cmk/gui/main.py
M cmk/gui/mobile.py
M cmk/gui/notify.py
M cmk/gui/page_menu.py
M cmk/gui/pagetypes.py
M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py
M cmk/gui/plugins/dashboard/failed_notifications.py
M cmk/gui/plugins/dashboard/stats.py
M cmk/gui/plugins/wato/background_job.py
M cmk/gui/plugins/wato/bi_config.py
M cmk/gui/plugins/wato/check_mk_configuration.py
M cmk/gui/plugins/wato/utils/base_modes.py
M cmk/gui/plugins/wato/utils/context_buttons.py
M cmk/gui/plugins/wato/utils/simple_modes.py
M cmk/gui/sidebar.py
M cmk/gui/table.py
M cmk/gui/userdb.py
M cmk/gui/valuespec.py
M cmk/gui/view_utils.py
M cmk/gui/views.py
M cmk/gui/visuals.py
M cmk/gui/wato/mkeventd.py
M cmk/gui/wato/pages/activate_changes.py
M cmk/gui/wato/pages/check_catalog.py
M cmk/gui/wato/pages/custom_attributes.py
M cmk/update_config.py
M cmk/utils/_type_defs_result.py
M cmk/utils/cpu_tracking.py
M omd/packages/omd/omdlib/contexts.py
M omd/packages/omd/omdlib/main.py
M omd/packages/omd/omdlib/utils.py
R tests/unit/checks/generictests/datasets/datapower_tcp_regression.py
R tests/unit/checks/generictests/datasets/winperf_tcp_conn_regression.py
M tests/unit/checks/test_generic_legacy_conversion.py
M tests/unit/cmk/base/checkers/test_agent.py
M tests/unit/cmk/base/checkers/test_cmd_caching.py
A tests/unit/cmk/base/plugins/agent_based/test_tcp_conn_stats.py
M tests/unit/cmk/fetchers/test_fetchers.py
M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py
M tests/unit/cmk/utils/test_cpu_tracking.py
M tests/unit/omdlib/test_omdlib_main.py
Log Message:
-----------
Merge branch 'master' into test_weblate2
Change-Id: I077fd83d9362e182b655193c69c9450599ba1993
Compare: https://github.com/tribe29/checkmk/compare/6b110d5d55bd...a4f93899e659