[checkmk-commits] [tribe29/checkmk] 1ae88e: Use a (single!) correct external command to remove...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 1ae88ebcb3a2b70da3cf9683b40d532758818513 https://github.com/tribe29/checkmk/commit/1ae88ebcb3a2b70da3cf9683b40d53275… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M cmk/gui/plugins/views/commands.py Log Message: ----------- Use a (single!) correct external command to remove a comment. Removing an acknowledgement via DEL_FOO_COMMENT is not correct, it just removes the comment in question, but not the acknowledged state. Doing a REMOVE_FOO_ACKNOWLEDGEMENT afterwards doesn't help either, there is nothing to be removed anymore... Change-Id: Iffddbb948ae23c5e939dd1340edd54ee0f88cf68 Commit: 5f3ad50ae85652920cc5d20614e30e2d47c9049f https://github.com/tribe29/checkmk/commit/5f3ad50ae85652920cc5d20614e30e2d4… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: A .werks/13076 M cmk/gui/plugins/openapi/restful_objects/decorators.py Log Message: ----------- 13076 FIX REST API, extend lock to encompass validation logic This Werk fixes a very severe data inconsistency problem in the REST API. Previously, only the actual working code of the individual endpoints were locked, but the validation logic which gets executed before the endpoints didn't fall into that locking scope. This logic could then trigger a cache load which could lead to data inconsistency and even data loss when using the REST API highly concurrently. The observed effects were: * when moving hosts concurrently, some hosts may disappear * when moving hosts concurrently, some hosts may end up in multiple folders * when editing hosts, spurious 421 or 401 responses could appear The locks have now been modified to encompass also the validation logic. This Werk fixes the afore mentioned problems. There are no further actions to be taken. Change-Id: I4323df250c4202ebb88c1d0a87694741e9eccb6e Commit: d8669b41fbef8f43fbf7e0ad18e9f61a9a5531fb https://github.com/tribe29/checkmk/commit/d8669b41fbef8f43fbf7e0ad18e9f61a9… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: A .werks/13079 M cmk/gui/fields/attributes.py Log Message: ----------- 13079 FIX REST API crash when setting SNMP credential In previous versions the REST API crashed with a HTTP 500 error when a SNMP credential of type "no_auth_no_cred" was being accessed or set. This Werk fixes this. There are no further actions necessary. Change-Id: I93699948505c446bae54a12a0fd2b1c9b9798505 Commit: 6e67f49ffe791ed7b47b73ced66e337334814f83 https://github.com/tribe29/checkmk/commit/6e67f49ffe791ed7b47b73ced66e33733… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-11-05 (Fri, 05 Nov 2021) Changed paths: M cmk/gui/fields/attributes.py Log Message: ----------- host/folder attributes: remove OrderedDict instances Change-Id: I5855cb07c2a9b45fe6f70cfe4b3c668f200f9729 Compare: https://github.com/tribe29/checkmk/compare/a4f116fe1dba...6e67f49ffe79