[checkmk-commits] [tribe29/checkmk] a3daf9: Replace cmk_links by host_url_from_context and ser...

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: a3daf98dff3e2da30204ae8c390705d1cc137bd0 https://github.com/tribe29/checkmk/commit/a3daf98dff3e2da30204ae8c390705d1c… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-08-22 (Thu, 22 Aug 2019) Changed paths: M cmk/notification_plugins/pagerduty.py M cmk/notification_plugins/utils.py Log Message: ----------- Replace cmk_links by host_url_from_context and service_url_from_context FEED-4107 Change-Id: I4433618d6b06fd1073aa18cb11291aaa0ab6cdb8 Commit: 18154dfe8e1bdbe418624d35e8fa899211f69e02 https://github.com/tribe29/checkmk/commit/18154dfe8e1bdbe418624d35e8fa89921… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-08-22 (Thu, 22 Aug 2019) Changed paths: A .werks/8787 M cmk/notification_plugins/mail.py M cmk/notification_plugins/pushover.py M cmk/notification_plugins/slack.py M cmk/notification_plugins/utils.py M cmk/notification_plugins/victorops.py M tests/unit/cmk/notifications/test_mail.py M tests/unit/cmk/notifications/test_slack.py M tests/unit/cmk/notifications/test_utils.py Log Message: ----------- 8787 FIX Links in the mail plugin were not displayed Instead of links to hosts and services the text '%s' was displayed in email notifications if the option 'URL prefix for links to Check_MK' was used. Effectively this commit nukes extend_context_with_link_urls. It is replaced by format_link together with host_url_from_context and service_url_from_context. They are pure functions which do not modify the notification context. Along the way new style format strings are replaced by old style format strings which resolves the issue. FEED-4107 Change-Id: I7b844fc1fd94e3cd743ed4dc73b827a8f0f79ea9 Compare: https://github.com/tribe29/checkmk/compare/ef432c29b63b...18154dfe8e1b