[checkmk-commits] [tribe29/checkmk] 384920: Remove text autocomplete

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 3849202f1e3e00a42b8ac2eae3c40a69e85c8848 https://github.com/tribe29/checkmk/commit/3849202f1e3e00a42b8ac2eae3c40a69e… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-12 (Wed, 12 May 2021) Changed paths: M web/htdocs/js/modules/valuespecs.js M web/htdocs/themes/facelift/scss/_main.scss Log Message: ----------- Remove text autocomplete CMK-6935 Change-Id: Iac56dc31d39e17c934c625bbd4adaca59180b94d Commit: 6e97584856ce19201b1b68c30f1852490157a643 https://github.com/tribe29/checkmk/commit/6e97584856ce19201b1b68c30f1852490… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-12 (Wed, 12 May 2021) Changed paths: M cmk/gui/htmllib.py M cmk/gui/plugins/dashboard/graph.py M cmk/gui/plugins/metrics/utils.py M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/valuespec.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/sites.py M cmk/gui/watolib/__init__.py M web/htdocs/js/modules/forms.js M web/htdocs/js/modules/valuespecs.js Log Message: ----------- Change text autocompletions by select2dropdowns Text autocompletion was originally designed only for monitored hostnames and configured hostnames. The text field allowed users to enter any value and also to edit configured values. Additionally pasting a string with particular characters(independent of autocomplete), would split it in the case of listofstring valuespec and create new fields. The text autocomplete suffered from some bugs and limitations: - Options availability bug. Sometimes the request would block and no new options would be fetched. Sometimes the workaround of clearing the field, changing focus and returning would restart the query. Sometimes worse in the case of configured hostnames, it was necessary to exit the page. - When request were not blocked, a request fired every onkeyup and when request came back it overwrote the user input. This commit exchanges the adhoc select2 dialog that floats on top of the html.input with a clean drop-down, managed entirely by select2 which directly ajax calls to request data. This allows for separated concerns, the python valuespec does not need to inject JS to place hooks to query the webapi. This fixes the following - The data availability bug, changing input starts a new query. Thus results are always found - Requests are triggered 250ms after User stops typing. This saves on requests. - Select2 cancels previous request as soon as the user changes input and only updates contents from the response of last request. This solves the bug of previous request updating results and confusing user. Old autocomplete valuespecs now inherit thus from dropdownchoice rather than text ascii. - Monitored Hostname. Now has regex input validation. User custom input is permitted - Configured Hostname. Now has regex input validation. User custom input is permitted - Monitored Service. Now has regex input validation. User custom input is permitted - Metric name. Now has input validation, metric name is strictly bound to known metrics - Hostname and service filters. Render directly the dropdowns as filters don't yet use the valuespecs. - Configured Hostname, can be embedded in listofstrings. List of strings is extended to expand on text input and text paste when the underlying datatype is a dropdown. It works as before. CMK-6935 Change-Id: I7c0dac8f4ee6deeaba7d614804500b7e98c1b95d Commit: 46c4f218636a01afc5bb620081feda4bcac87fcf https://github.com/tribe29/checkmk/commit/46c4f218636a01afc5bb620081feda4bc… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-12 (Wed, 12 May 2021) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/infos.py M cmk/gui/valuespec.py M tests/unit/cmk/gui/test_pages.py M web/htdocs/js/modules/valuespecs.js M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Customgraphs editor use only select2 In order to use the modern autocomplete dropdowns for input in host, service, and metric the old valuespec is completely removed. Functionality is good enough - There is no automatic refresh on any form action. This is even a feature request: SUP-2485, SUP-5399, SUP-5949 - Added an apply button to save changes - No need for metric & scalar selector ajax pages. The autocompleter covers all - Because no form & page refresh, can drop the JS part that did that, and caused some bugfixing headaches when styles were changes. All dropdowns use id instead of name like text_input In the single info cases and custom graphs editor, where only a specific hostname, service, and metric make sense enforce that constrain instead of allowing user to write anything. Filters have direct html render, enforce the exact match op=="=" for only what is autocompleted. Change-Id: I685fc48418ae3f743068cbdbd27f2ea3839f5c5c Commit: 431674fe246ee169e9a376fc804ede5f850b6c1f https://github.com/tribe29/checkmk/commit/431674fe246ee169e9a376fc804ede5f8… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-12 (Wed, 12 May 2021) Changed paths: M cmk/gui/valuespec.py M web/htdocs/js/modules/valuespecs.js Log Message: ----------- Autocompleter options mention incomplete results first This announces user that the list could be incomplete. User can't select as option, it is a warning only not an option Change-Id: If87bc39c91fbbcdf03b428cb023fa051193cbb7d Commit: 6aaf20a4883ffad2245e51e02e6fb8c5ff798b16 https://github.com/tribe29/checkmk/commit/6aaf20a4883ffad2245e51e02e6fb8c5f… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-12 (Wed, 12 May 2021) Changed paths: A .werks/12491 Log Message: ----------- 12491 No autorefresh in Custom Graph editor The custom graph editor in a pursuit of convenience would save changes and refresh the page on every change. This convenience resulted in a high performance penalty when editing graphs with multiple metrics, as the entire page would need to be rendered again, and specially recollecting data from the RRD files. With this Werk, the custom graph editor does not execute the page reload upon changes. The user is now responsible for this interaction. Following our UX project, now there is an "Apply" button on the top left corner of the editor to save and apply the changes to the graph. This allows users to place multiple changes at once, without incurring in a performance penalty, due to the constant refreshing of the editor. Users do need to press the "Apply" button to save changes, it is now not enough to just do changes and leave the editor. Change-Id: Ibd3e8f44859300fe9e2de895884348621c877245 Commit: da65fbdebcc0f7df6324344dc003ae16cd3b2bde https://github.com/tribe29/checkmk/commit/da65fbdebcc0f7df6324344dc003ae16c… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-05-12 (Wed, 12 May 2021) Changed paths: M cmk/gui/visuals.py Log Message: ----------- Fix Dashboards show context info in title Context filters can be configured on the dashboard settings. Those filters were applied yet did not appear on the title. Only after using the sidebar filter actions would they be loaded on the url and then applied to the title. The context is already merged on the dashboard, and that should be the only source for action. No last instant query to the uri vars. Views load at some point the merged context to the uri, that should be refactored away. Dashboard with context filters is new and that has not been incorporated( good ). This commit uses the merge context as the source of information for the context sensitive title. Hopefully in later refactor can the filters stop peaking to the uri vars for action. SUP-6284 Change-Id: I2274f56491d0173d69a5bc386a54f13f2dd179ac Commit: 9c88fd3af75d8426af5f905aa11b2dd3333c5ff7 https://github.com/tribe29/checkmk/commit/9c88fd3af75d8426af5f905aa11b2dd33… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-05-12 (Wed, 12 May 2021) Changed paths: M cmk/gui/fields/__init__.py Log Message: ----------- REST API: remove abstract IP class Change-Id: I20e7220bed3ac5ea4842cce12cf75df4edcce6e6 Commit: a6866c25e91d2e67132d543dc87efeaca004437d https://github.com/tribe29/checkmk/commit/a6866c25e91d2e67132d543dc87efeaca… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2021-05-12 (Wed, 12 May 2021) Changed paths: M cmk/gui/inventory.py Log Message: ----------- Format line Change-Id: Ieede7f5499859aa664e43f3fb541b237303d001b Compare: https://github.com/tribe29/checkmk/compare/318d6dddea8b...a6866c25e91d