[checkmk-commits] [tribe29/checkmk] f758bb: Add tests for cisco_sensor_item.include

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f758bbf606ed241b5003eeb1428a30ed6fb79a2e https://github.com/tribe29/checkmk/commit/f758bbf606ed241b5003eeb1428a30ed6… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-11-26 (Tue, 26 Nov 2019) Changed paths: A tests/unit/checks/test_cisco_sensor_item_include.py Log Message: ----------- Add tests for cisco_sensor_item.include SUP-1192 Change-Id: Iec02736b0918f8a0ce280f075ff3728aa6c6983b Commit: d06814474709f5d25d46d2b8c9add6cf861057ae https://github.com/tribe29/checkmk/commit/d06814474709f5d25d46d2b8c9add6cf8… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-11-26 (Tue, 26 Nov 2019) Changed paths: M checks/cisco_sensor_item.include M checks/cisco_temp_perf Log Message: ----------- Minor cleanup for cisco_sensor_item * rename trial_string to description * rename fall_back to sensor_id since it's numeric * remove unnecessary lstrip() * remove comments that explain the control flow * remove commented out code mentioning cisco_sensor_item SUP-1192 Change-Id: I6072a69992cb3857d6add79bb9abb0555cb8dac9 Commit: e960810a4e8a03b164da39c4bd20f36f439e584f https://github.com/tribe29/checkmk/commit/e960810a4e8a03b164da39c4bd20f36f4… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-11-26 (Tue, 26 Nov 2019) Changed paths: A .werks/10463 M checks/cisco_sensor_item.include M tests/unit/checks/test_cisco_sensor_item_include.py Log Message: ----------- 10463 FIX cisco_power: discover unique items in one edge case For some sensor descriptions the cisco_power check discovered items that were not unique. One description was e.g. "Sw1, PSA Normal" which was translated into the item "Sw1". Another sensor that used the description "Sw1, PSB Normal" was then aliased to "Sw1" as well. Such items can now be differentiated. The example sensors would now be mapped to the items "Sw1 PSA {ID}" and "Sw1 PSB {ID}" where {ID} is the ID of the sensor. The affected services have to be rediscovered. SUP-1192 Change-Id: I3895b355595ae69171daa9eae003f98e5c0b783c Compare: https://github.com/tribe29/checkmk/compare/ec5223693813...e960810a4e8a