[checkmk-commits] [tribe29/checkmk] f9a767: Remove deprecated wheel event handlers in sidebar.js

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f9a7674eb667b5bc9d0436e5f8ab2b140815a3bc https://github.com/tribe29/checkmk/commit/f9a7674eb667b5bc9d0436e5f8ab2b140… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-09-02 (Mon, 02 Sep 2019) Changed paths: M web/htdocs/js/modules/sidebar.js Log Message: ----------- Remove deprecated wheel event handlers in sidebar.js We now always use addEventListener together with a wheel event for scrolling inside the sidebar. Although wheel events in general may not reflect the correct scrolling direction, we leave a wheel handler in place here for now. Change-Id: I9f533b4613a9ed9466745ee120c30645fd9ebd64 Commit: 104090444ddae7c77df8c80aa4b4fe7175007731 https://github.com/tribe29/checkmk/commit/104090444ddae7c77df8c80aa4b4fe717… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-09-02 (Mon, 02 Sep 2019) Changed paths: M web/htdocs/js/modules/sidebar.js Log Message: ----------- Cleanup returnValue, preventDefault and stopPropagation Remove returnValue and always use preventDefault and stopPropagation. All our supported browsers support preventDefault and stopPropagation. Change-Id: I125e7d67e44cfd0ac28484f039cace885f6970e0 Commit: bdcf0e3245f97e392926841daffb7b8b7b7812b1 https://github.com/tribe29/checkmk/commit/bdcf0e3245f97e392926841daffb7b8b7… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-09-02 (Mon, 02 Sep 2019) Changed paths: M web/htdocs/js/modules/sidebar.js Log Message: ----------- Don't check for window.event and don't return inside scrollWheel The return value is ignored anyway and the use of window.event should be avoided: https://developer.mozilla.org/en-US/docs/Web/API/Window/event Change-Id: I91a8fd748c91d05e2e785fb5cade94687b6378bc Commit: 81150d39c5ef0f2c2566cbe754aea52078930799 https://github.com/tribe29/checkmk/commit/81150d39c5ef0f2c2566cbe754aea5207… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2019-09-02 (Mon, 02 Sep 2019) Changed paths: M web/htdocs/js/modules/sidebar.js Log Message: ----------- Resolve scrolling error in the Chrome console When a user scrolled inside the sidebar errors with the message: Unable to preventDefault inside passive event listener due to target being treated as passive. were logged to the console. This is fixed by removing the preventDefault call. Since the sidebar always has a height of 100% no default scrolling action will be applied. This was the behaviour for Chrome anyway since the event listener is passive by default: https://www.chromestatus.com/features/6662647093133312 Change-Id: I4ab522ad4e4e2b2b2221397817296fde8a95fce4 Compare: https://github.com/tribe29/checkmk/compare/eccd246e5a7c...81150d39c5ef