[checkmk-commits] [tribe29/checkmk] d99d18: Make code slightly more pythonic

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d99d18dc352521e8d95133f231acf12075c3dd94 https://github.com/tribe29/checkmk/commit/d99d18dc352521e8d95133f231acf1207… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-03-25 (Wed, 25 Mar 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/data_sources/tcp.py M tests-py3/unit/cmk/base/data_sources/test_tcp_data_source.py Log Message: ----------- Make code slightly more pythonic - expose `port` and `timeout` as properties - do not test len(data) == 0, empty sequences are falsy - break loop in test and leave the normal execution of the loop unindented CMK-3742 Change-Id: Ie15c8bb5f5d73188a7c1dce42d62f69c45571bb4 Commit: 345df589f5a8bb4ed0619f3332d1e640871da905 https://github.com/tribe29/checkmk/commit/345df589f5a8bb4ed0619f3332d1e6408… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-03-25 (Wed, 25 Mar 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/data_sources/abstract.py Log Message: ----------- Rename _parse_info -> _parse_host_section clarifies the intent CMK-3742 Change-Id: I1bc671fefd1d95e6cf33488a2700016e4a9f912a Commit: 8d4851bc8172dc0284c1939527dea59adcc6ee32 https://github.com/tribe29/checkmk/commit/8d4851bc8172dc0284c1939527dea59ad… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-03-25 (Wed, 25 Mar 2020) Changed paths: M cmk/base/data_sources/tcp.py M tests-py3/unit/cmk/base/data_sources/test_tcp_data_source.py Log Message: ----------- Test TCPDataSource._decrypt and refactor This refactoring is similar to "Replace Nested Conditional With Guard Clauses", for readability. Diff this patch with `--ignore-all-space`. See Also: https://refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.ht… CMK-3742 Change-Id: I9358b758c578eeffa27c8e4f8599298c7c5e9278 Compare: https://github.com/tribe29/checkmk/compare/9aa171c13ce0...8d4851bc8172