[checkmk-commits] [Checkmk/checkmk] e12b28: acknowledge problems: basic UX rework

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: e12b28a3a4cfbea12bc4bee179ac55fd3ce56a45 https://github.com/Checkmk/checkmk/commit/e12b28a3a4cfbea12bc4bee179ac55fd3… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M cmk/gui/views/command/commands.py M cmk/gui/wato/_check_mk_configuration.py M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- acknowledge problems: basic UX rework * more verbose command options * date and time picker CMK-14105 Change-Id: I6d8bfbe0e06f454748d95166ad55a76196a926ee Commit: 7563897b638c4f653233f23be2968c4802a05d60 https://github.com/Checkmk/checkmk/commit/7563897b638c4f653233f23be2968c480… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M cmk/gui/htmllib/html.py M cmk/gui/valuespec.py M cmk/gui/views/command/commands.py Log Message: ----------- date and time picker: onclick to onchange change the used JS event listener from onclick to onchange Change-Id: I74b621b3fbd7f9a02c6c046c7bec02546256ee9e Commit: a95d2d6c403ffc69e27f1bd3e1897ea53470a676 https://github.com/Checkmk/checkmk/commit/a95d2d6c403ffc69e27f1bd3e1897ea53… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M cmk/gui/forms.py M cmk/gui/views/command/commands.py M web/htdocs/js/modules/forms.ts M web/htdocs/themes/facelift/scss/_main.scss M web/htdocs/themes/facelift/scss/_page_menu.scss M web/htdocs/themes/facelift/scss/_variables.scss M web/htdocs/themes/modern-dark/scss/_variables.scss Log Message: ----------- view command buttons: improve UX for commands "Acknowledge problems" and "Schedule downtimes" * the submit buttons are disabled as long as no comment is entered * the cancel buttons reload the given page, ignoring any changes made to the command form CMK-14091 Change-Id: I1a00322ec87c2c0bdc16dc8d1a2dd78981581c03 Commit: 74e61194dc11bed5ad9873af6222ac1f062a3aeb https://github.com/Checkmk/checkmk/commit/74e61194dc11bed5ad9873af6222ac1f0… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M cmk/gui/view_utils.py M cmk/gui/views/command/commands.py M web/htdocs/js/modules/page_menu.ts M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- acknowledge problems: some UX improvements * the "Expire on" option is activated, onchange of the date or time input field * an upgrade button for the CRE is added to the "Expire on" option CMK-14091 Change-Id: I9ffb9ba2afcbb66ebdc47147f08528572e53d20d Commit: 2aea0ebbc20e870a807651473692cddfec8c4bf0 https://github.com/Checkmk/checkmk/commit/2aea0ebbc20e870a807651473692cddfe… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M cmk/gui/view_renderer.py M cmk/gui/views/command/commands.py Log Message: ----------- fix command property 'show_command_form' ... to toggle whether or not a command form is shown. in case the property is False, go to the confirm dialog right away Change-Id: I1f6c3680502dc9c679d4545448b8b199bf9ccef4 Commit: a1537139da41b2780c59178a5996918cc8107725 https://github.com/Checkmk/checkmk/commit/a1537139da41b2780c59178a5996918cc… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M cmk/gui/views/command/base.py M cmk/gui/views/command/commands.py M tests/unit/cmk/gui/views/test_views.py M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- acknowledge problems: new separate command "Remove acknowledgments" ... and more verbose confirm dialogs for both the acknowledge and the remove acknowledgments commands CMK-14105 Change-Id: Ie8f1376ae142b361c09a5ec71d8060e135057cd9 Commit: 7443224bb7ec0010edb05cec16b8eb7f7828e453 https://github.com/Checkmk/checkmk/commit/7443224bb7ec0010edb05cec16b8eb7f7… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: A cmk/gui/utils/time.py M cmk/gui/views/command/base.py M cmk/gui/views/command/commands.py M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- date and time in commands: add timezone UTC offset CMK-14105 Change-Id: I2bd770cd81bbbc5e9a6606940b5a8bea649bc3b7 Commit: 13638e6788c009e9f46d6d6acab97c15185fd987 https://github.com/Checkmk/checkmk/commit/13638e6788c009e9f46d6d6acab97c151… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M cmk/gui/utils/confirm_with_preview.py M cmk/gui/views/command/base.py M cmk/gui/views/command/commands.py M cmk/gui/views/command/form.py M web/htdocs/js/modules/forms.ts Log Message: ----------- command confirm dialog: apply a third 'deny' button besides the confirm and the cancel button, our confirm dialogs may now be rendered with a third 'deny' button. this is implemented for the dialog in commands "Acknowledge problems" and "Schedule downtimes". CMK-14105 Change-Id: Ic327db7b3112a5b397928295cc7e8a4f975f7e35 Commit: 612d66e25b1aa52fa6b43dc92ffc63b5a0ec7704 https://github.com/Checkmk/checkmk/commit/612d66e25b1aa52fa6b43dc92ffc63b5a… Author: Kenneth Okoh <kenneth.okoh(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M cmk/gui/plugins/config/base.py M cmk/gui/valuespec.py M cmk/gui/views/command/commands.py M cmk/gui/wato/_check_mk_configuration.py M cmk/update_config/plugins/actions/global_settings.py M tests/unit/cmk/gui/test_gui_config.py M tests/unit/cmk/gui/watolib/test_watolib.py Log Message: ----------- acknowledge problems: update config variables CMK-14105 Change-Id: I0f22e0e94a15338060aa2fb8f37d49e90cd06231 Commit: 6fe8fbcc843824ba2122a5ca3d18f36823f7293a https://github.com/Checkmk/checkmk/commit/6fe8fbcc843824ba2122a5ca3d18f3682… Author: Leonardo Petrora <leonardo.petrora(a)checkmk.com> Date: 2023-12-07 (Thu, 07 Dec 2023) Changed paths: M web/htdocs/themes/facelift/scss/_pages.scss Log Message: ----------- Remove red shadow from password fields The passowrd field had a red stroke as if an incorrect value had been entered. The stroke was removed and the password fields look similar to the text fields. CMK-14911 Change-Id: Ia28ae5e3550a9e01c44a13f4542289b768e2a3ed Compare: https://github.com/Checkmk/checkmk/compare/7d0092dc8495...6fe8fbcc8438