[checkmk-commits] [Checkmk/checkmk] d7f35d: 17258 Fix host not renaming when node of cluster

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: d7f35d0653eadd7e49b5c815c6fa2e6c647ba5a1 https://github.com/Checkmk/checkmk/commit/d7f35d0653eadd7e49b5c815c6fa2e6c6… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-09-25 (Wed, 25 Sep 2024) Changed paths: A .werks/17258.md M cmk/gui/watolib/host_rename.py A tests/unit/cmk/gui/watolib/test_host_rename.py Log Message: ----------- 17258 Fix host not renaming when node of cluster Due to a bug in our cache invalidation mechanism hosts were not renamed when they were a) in a subfolder and b) a node of a cluster. This commit fixes the issue by moving the Host.all() call to after the hosts were renamed. This is only a workaround/hotfix and doesn't address the underlying bug as this might require a bigger refactoring: The folder._hosts is not cleared by the cache invalidation but even if, it would not be invalidated everywhere as not every folder object is in the subfolder hierarchy of the root folder. SUP-18050 Change-Id: I14fd54a80c49466f034b4e83bf77646cec01c75e Commit: d5660bad6226aafa71f1ab0cc251481e01fadb6f https://github.com/Checkmk/checkmk/commit/d5660bad6226aafa71f1ab0cc251481e0… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-09-25 (Wed, 25 Sep 2024) Changed paths: M cmk/gui/watolib/hosts_and_folders.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Add test and warning about faulty cache invalidation folder_tree().invalidate_caches() will not invalidate all folder caches. You might have some references in your code which are not part of the root_folder() hierarchy since the root folder python object is regenerated after calling this method (since we are dropping "wato_folders"), losing all references to its subfolders. This leads to the recursive .drop_caches missing them them. CMK-19211 Change-Id: I8574b8c521e5c2340ad805102b3e6aa8f4ba3035 Commit: 7d90762de105d5222a4da3a1270689d2ca86ad62 https://github.com/Checkmk/checkmk/commit/7d90762de105d5222a4da3a1270689d2c… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-09-25 (Wed, 25 Sep 2024) Changed paths: M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/network_scan.py M cmk/post_rename_site/plugins/actions/hosts_and_folders.py M cmk/update_config/plugins/actions/create_precompiled_files.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Make cache invalidation on save an explicit call This changes no functionality but will facilitate a followup Change-Id: I071e3a7daf395d52e3370bf9bfff494ca99c8260 Commit: 762943236e8d928112625ad6f72355d9501c3e29 https://github.com/Checkmk/checkmk/commit/762943236e8d928112625ad6f72355d95… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-09-25 (Wed, 25 Sep 2024) Changed paths: M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/network_scan.py M cmk/post_rename_site/plugins/actions/hosts_and_folders.py M cmk/update_config/plugins/actions/create_precompiled_files.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Make explicit who saves folder vs folder attributes Another commit which functionally changes nothing to make the intent of the call sites more clear Change-Id: I0db60179fd69c3651ef5e94246d3473778a4cffc Commit: 992b0f58beea8de5d679b7a14bdbb6b45df63355 https://github.com/Checkmk/checkmk/commit/992b0f58beea8de5d679b7a14bdbb6b45… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-09-25 (Wed, 25 Sep 2024) Changed paths: M cmk/gui/watolib/custom_attributes.py M cmk/gui/watolib/host_rename.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/tags.py Log Message: ----------- setup: Simplify hosts saving Change-Id: I1090e36db17a73611f304799073bd3cbcae86d3c Commit: 7c66d0497145050351d8209c5be73bf67451c0fe https://github.com/Checkmk/checkmk/commit/7c66d0497145050351d8209c5be73bf67… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-09-25 (Wed, 25 Sep 2024) Changed paths: M cmk/gui/cre/registration.py M cmk/gui/painter/v0/painters.py Log Message: ----------- Clean up edition specific PainterDowntimeRecurring The previous implementation registered this painter in all editions. There are built-in views shipped which contain this printer for all editions. For the Raw edition there was an edition specific renderer registered which statically printed "(not supported)". Instead of registering a printer displaying this static text, we now simply do not register the painter at all, which removes the need for a edition specific monkey patch. The view will then silently not display the printer, which should be fine from the user's perspective. Change-Id: Ic2b3db45d75208efcdc82b9d2cfad25578cb8e95 Compare: https://github.com/Checkmk/checkmk/compare/f834e9781237...7c66d0497145 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications