Module: check_mk
Branch: master
Commit: 28041e802bc8a334abd72ee11f7606c3d6a4e433
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=28041e802bc8a3…
Author: Sven Panne <sp(a)mathias-kettner.de>
Date: Thu Jul 19 08:55:59 2018 +0200
Classify attribute-defined-outside-init warning.
Change-Id: I3e4e7ec80691234b34aecf3d1fe4e36601d6668b
---
tests/pylint/pylintrc | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc
index 910612a..3ce8a12 100644
--- a/tests/pylint/pylintrc
+++ b/tests/pylint/pylintrc
@@ -12,7 +12,6 @@ persistent=yes
[MESSAGES CONTROL]
disable=
- attribute-defined-outside-init,
bad-continuation,
bad-indentation,
bad-whitespace,
@@ -81,6 +80,12 @@ disable=
# real bugs. Just some work to do...
unused-variable,
#---------------------------------------------------------------------------
+ # Enabling this would be very desirable, it vastly improves readability and
+ # it might even be necessary for tools like mypy. Fixing this involves some
+ # amount of relatively easy work, especially if we want to avoid code
+ # duplication (introduce new classes, combine methods, etc.)
+ attribute-defined-outside-init,
+ #---------------------------------------------------------------------------
# Enabling this would be nice, but not crucial. At the moment, we have quite
# a few violations, so we postpone fixing this. When we do it eventually, we
# probably want to use "include-naming-hint=yes" in the BASIC section.