[checkmk-commits] 6938 FIX cmk-update-agent: Handle failing package manager

Module: check_mk Branch: master Commit: 0ed40af72dc95d6fd3dbf1f2e2f5eaa321ac49c5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0ed40af72dc95d… Author: Andreas Umbreit <au(a)mathias-kettner.de> Date: Fri Jan 18 16:57:50 2019 +0100 6938 FIX cmk-update-agent: Handle failing package manager This werk fixes two bugs that occur on Unix and Linux when the invoked package manager fails to install an agent package: The agent updater saved the agent hash to its state file immediately before the update takes place. As a result, an agent package got recognized as installed even if its installation failed. (Regression since Check_MK 1.5) Due to inproper handling of the stderr and stdout streams coming from the invoked package manager, the agent updater crashed on a package manager failure instead of forwarding the error messages to the user or log. (Jira: CMK-1552) Change-Id: I47668286c465145cbe43d00469e030201cdbfe7e --- .werks/6938 | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/.werks/6938 b/.werks/6938 new file mode 100644 index 0000000..fef6715 --- /dev/null +++ b/.werks/6938 @@ -0,0 +1,25 @@ +Title: cmk-update-agent: Handle failing package manager +Level: 1 +Component: agents +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.6.0i1 +Date: 1547826201 + +This werk fixes two bugs that occur on Unix and Linux +when the invoked package manager fails to install an +agent package: + +The agent updater saved the agent hash to its state file +immediately before the update takes place. As a result, an +agent package got recognized as installed even if +its installation failed. + +(Regression since Check_MK 1.5) Due to inproper handling +of the stderr and stdout streams coming from the invoked +package manager, the agent updater crashed on a package +manager failure instead of forwarding the error messages +to the user or log. +