[checkmk-commits] [tribe29/checkmk] c0ffd5: DRAFT Remove data generator class for dashlet

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c0ffd57aaaf6556c07e0fda01f6fd5a0c63b5d31 https://github.com/tribe29/checkmk/commit/c0ffd57aaaf6556c07e0fda01f6fd5a0c… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/dashboard/utils.py M tests/unit/cmk/gui/test_pages.py M web/htdocs/js/modules/figures/cmk_gauge.js Log Message: ----------- DRAFT Remove data generator class for dashlet Currently dashlets query an ajax endpoint, which is just a page, that replies to the dashlet data generator. These data generators come in a pair match to dashlet and thus become to rigid to serve multiple dashlets that only require a subset of the data or worse that can incompatible render attributes. Inspecting the ABCDatagenerator the only relevant method is generate_response_from_request. Within it, it was already capable to find the dashlet being draw, yet it extracted the configuration valuespec out of itself(DataGenerator) instead of the Dashlet, which is the correct candidate to know the required configuration valuespec. This refactoring taking as example the Single metric source, that can be displayed as a Gauge(w/o history) or Single Graph(w/o history) for a specific host and service or a Barplot with current value for multiple hosts. All configuration valuespec is transferred to the dashlets. Datagenerator is removed leaving some middle ware not to break other dashlets. And the WEB API ajax endpoint is named for single metric, but could easily process all new figure dashlets, because the dashlet type is recognized during processing not on API endpoint. The specificity of the configuration valuespec at the dashlet level allows for flexible and unique dashlet endpoint and correct data validation. Change-Id: I15b8561f1011a44f09348cfb3005af715ca484ea Commit: cb1aca74d959cab1fe6fa06883e1ad5f782c41f0 https://github.com/tribe29/checkmk/commit/cb1aca74d959cab1fe6fa06883e1ad5f7… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/utils.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Dashlet scatterplot: migrate vs_parameters to dashlet As proposed in previous draft. Dashlets need to keep the ownership of their parameters. Data generators only process Request on backend. No need for special page per dashlet. Change-Id: I9ededa2a9d37182d9dbb4cd4753710e190fad7b4 Commit: 4fbe28cdf7755b2586088e7216df4c3b7d0e8619 https://github.com/tribe29/checkmk/commit/4fbe28cdf7755b2586088e7216df4c3b7… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/alert_statistics.py M cmk/gui/plugins/dashboard/site_overview.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Dashlets: Site Overview & Alert statistics transfer vs Change-Id: I68df2bb3739fdf708ddbe812877d045f2c6abe30 Commit: 6ce54dc5072557048e67ab1a2b4b7b30872fecbe https://github.com/tribe29/checkmk/commit/6ce54dc5072557048e67ab1a2b4b7b308… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Moved bar charts to work without its data generator - Simplified title. It belongs to dashlet not data generator - The legend had repeated to title. Beforehand agreed to drop that. - For the moment workaround make all classmethods instance methods to track log_class & type. Will be simplified next Change-Id: I2d47833f0684809b3d7b692c532c862403d04e84 Commit: 5728703adf05d49c51803a95ebcd3f47214f010a https://github.com/tribe29/checkmk/commit/5728703adf05d49c51803a95ebcd3f472… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py Log Message: ----------- Dashlets: Alerts and notifications move vs_parameters to dashlets Change-Id: Ic400f2c3aacfbdae9e72c5cb48675b6f4c0fd034 Commit: 48da7735c59ed32d91e558b590c4abcd83de8dea https://github.com/tribe29/checkmk/commit/48da7735c59ed32d91e558b590c4abcd8… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/__init__.py M cmk/gui/plugins/dashboard/alert_statistics.py M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/dashboard/site_overview.py M cmk/gui/plugins/dashboard/utils.py Log Message: ----------- Discard the need for the ABCDataGenerator - Old DataGenerator subclasses just keep the name for cohesion, they act now as a namespace. - All figure dashlets now query a single figure dashlet API endpoint. Which validates Dashlet specific input. Change-Id: I4dea6b0b0756e61f213eacb971e10634a5c1f694 Compare: https://github.com/tribe29/checkmk/compare/39ebd99273b0...48da7735c59e