28 Sep
2020
28 Sep
'20
2:31 p.m.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: be9894bde6112e446ce8abd052d9f5ba80e029a2
https://github.com/tribe29/checkmk/commit/be9894bde6112e446ce8abd052d9f5ba8…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M .werks/11363
M checkman/if64
R checkman/if64adm
M cmk/base/.f12
M cmk/base/api/agent_based/utils.py
M cmk/base/config.py
M cmk/base/plugins/agent_based/agent_based_api/v1/__init__.py
M cmk/base/plugins/agent_based/aix_if.py
M cmk/base/plugins/agent_based/emc_vplex_if.py
M cmk/base/plugins/agent_based/hitachi_hnas_fc_if.py
M cmk/base/plugins/agent_based/hp_msa_if.py
M cmk/base/plugins/agent_based/hpux_if.py
M cmk/base/plugins/agent_based/if32.py
M cmk/base/plugins/agent_based/if64.py
M cmk/base/plugins/agent_based/if64_tplink.py
R cmk/base/plugins/agent_based/if64adm.py
M cmk/base/plugins/agent_based/if_brocade_lancom.py
M cmk/base/plugins/agent_based/if_fortigate.py
M cmk/base/plugins/agent_based/mcdata_fcport.py
M cmk/base/plugins/agent_based/statgrab_net.py
M cmk/base/plugins/agent_based/ucs_bladecenter_if.py
M cmk/base/plugins/agent_based/utils/if64.py
M cmk/base/plugins/agent_based/utils/interfaces.py
M cmk/base/plugins/agent_based/vms_if.py
M cmk/gui/plugins/metrics/translation.py
M cmk/gui/plugins/views/perfometers/check_mk.py
M cmk/gui/plugins/wato/check_parameters/if.py
M cmk/update_config.py
Log Message:
-----------
11363 if64, if64adm: Monitoring of the admin status <tt>ifAdminStatus</tt>
for switch ports
This werk is only relevant for users who are currently monitoring the admin status
<tt>ifAdminStatus</tt> of switch ports (check plugin
<tt>if64adm</tt>).
The 64-bit version of the interface check for switch ports can be configured to
also monitor the admin status <tt>ifAdminStatus</tt>. Up to now, if this
option
was activated, Checkmk used the check plugin <tt>if64adm</tt> instead of
<tt>if64</tt>. Furthermore, only an <tt>ifAdminStatus</tt> of 2
was reported by
setting the port state to <i>9 - admin down</i>. With this werk, the admin
status is monitored completely separately from the port state. Consequently, the
port state <i>9 - admin down</i> is not available any more.
Previously, the monitoring of the admin state was activated implicitly by configuring
Checkmk to discover ports in the state <i>9 - admin down</i> (rule
"Network Interface
and Switch Port Discovery"). Now, this is handled via the rule for including and
excluding SNMP sections ("Include or exclude SNMP sections"). If and only if the
section
<tt>if64adm</tt> is enabled via this rule, the admin status will be
monitored,
independently of the configuration in "Network Interface and Switch Port
Discovery".
Furthermore, since the admin status is now reported separately from the port state,
it can also be used to configure 1) the discovery of network interfaces (rule
"Network
Interface and Switch Port Discovery"), 2) the monitoring state (rule "Network
interfaces
and switch ports"). For example, you can make Checkmk discover only interfaces with
an admin status of 2 or you can set the monitoring state of all interfaces with an
admin status of 1 to WARNING. Note that these configuration options only have an effect
if the admin status is actually monitored, i.e., if the section
<tt>if64adm</tt> is
enabled.
Moreover, contrary to before, from now on, no re-discovery is necessary after activating
or deactivating the monitoring of the admin status. This is because this werk combines
the
check plugins <tt>if64</tt> and <tt>if64adm</tt> into a single
plugin called <tt>if64</tt>.
This change is incompatible for all users who are currently monitoring the admin
status using <tt>if64adm</tt>. These users should follow these steps:
<ul>
<li>Activate the monitoring of the admin status by enabling the section
<tt>if64adm</tt>
via the rule "Include or exclude SNMP sections".</li>
<li>Check the discovery configuration (rule "Network Interface and Switch Port
Discovery"). As mentioned above, the admin state can now be used to further refine
the
discovery of network interfaces. On the other hand, the port state <i>9 - admin
down</i>
is not available any more, so users might have to adjust their configurations.</li>
<li>Re-discover the services of affected hosts.</li>
<li>Check the monitoring configuration (rule "Network interfaces and switch
ports").
Analogously to the discovery configuration, the admin state can now be used to set
the monitoring state of network interfaces and the port state <i>9 - admin
down</i>
is not available any more.</li>
<li>Finally, check if there are any rules of the type "Bulk walk: Limit SNMP
OID ranges"
where the option "SNMP interface check with 64 bit counters using admin states (using
v2c)"
is selected (this will now be displayed as "Element 'if64adm' does not exist
anymore").
Change these to "SNMP interface check with 64 bit counters (using v2c)". This is
necessary
because, as mentioned above, the check plugin <tt>if64adm</tt> does not exist
any more.
</li>
</ul>
CMK-5414
Change-Id: I4f2f224d1e4dad32d87d506db81c73258d6b5ab3
Commit: 4280909108f4d0200d6ed46c1fccd84e6b216777
https://github.com/tribe29/checkmk/commit/4280909108f4d0200d6ed46c1fccd84e6…
Author: Joerg Herbel <joerg.herbel(a)tribe29.com>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M cmk/base/api/agent_based/register/section_plugins.py
M cmk/base/api/agent_based/type_defs.py
M cmk/base/checkers/snmp.py
M cmk/snmplib/type_defs.py
M tests/unit/cmk/base/api/agent_based/register/test_section_plugins.py
M tests/unit/cmk/base/checkers/test_snmp_data_source.py
R tests/unit/cmk/snmplib/test_snmp_type_defs.py
Log Message:
-----------
Remove mechanism for dynamic, rule-based SNMP detection specifications
The new rule for disabling SNMP sections (werk #11114) made the
mechanism for dynamically computing SNMP detection specifications
unncessary.
CMK-5414
Change-Id: I2766de1edf771e940130b7cd32fcf19e262e1cf4
Commit: fcce7fbeb24346529abde96a17fe8c420d5082a1
https://github.com/tribe29/checkmk/commit/fcce7fbeb24346529abde96a17fe8c420…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-09-28 (Mon, 28 Sep 2020)
Changed paths:
M cmk/fetchers/controller.py
Log Message:
-----------
Post review cleanups
Change-Id: I7f7438a8a47209af3cac993eae058bc2eacdfd18
Compare: https://github.com/tribe29/checkmk/compare/c3e5c4392711...fcce7fbeb243