[checkmk-commits] 6182 FIX Users: Fixed misleading message "User synchronization successful" when opening users page

Module: check_mk Branch: master Commit: 80eddba50341daf382347ac46d3e9a328390fe86 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=80eddba50341da… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon May 28 09:28:44 2018 +0200 6182 FIX Users: Fixed misleading message "User synchronization successful" when opening users page Sometimes, after the user sync has been executed, when opening the users page, it showed the message "User synchronization successful" even when no user synchronization is configured. This message is not shown anymore. Change-Id: I2cbfc6b89494c2575259e2796a564d8b243dd44d --- .werks/6182 | 13 +++++++++++++ web/htdocs/wato.py | 6 +++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.werks/6182 b/.werks/6182 new file mode 100644 index 0000000..27fae6a --- /dev/null +++ b/.werks/6182 @@ -0,0 +1,13 @@ +Title: Users: Fixed misleading message "User synchronization successful" when opening users page +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.6.0i1 +Date: 1527492452 + +Sometimes, after the user sync has been executed, when opening the users page, it showed the +message "User synchronization successful" even when no user synchronization is configured. +This message is not shown anymore. diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 6ff6b96..5c78e66 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -10911,11 +10911,11 @@ class ModeUsers(WatoMode): url = html.makeuri([]) html.immediate_browser_redirect(2, url) - elif self._job_snapshot.state() == gui_background_job.background_job.JobStatus.state_finished and not\ - self._job_snapshot.acknowledged_by(): + elif self._job_snapshot.state() == gui_background_job.background_job.JobStatus.state_finished \ + and not self._job_snapshot.acknowledged_by(): # Just finished, auto-acknowledge userdb.UserSyncBackgroundJob().acknowledge(config.user.id) - html.message(_("User synchronization successful")) + #html.message(_("User synchronization successful")) elif not self._job_snapshot.acknowledged_by() and self._job_snapshot.has_exception(): # Finished, but not OK - show info message with links to details