[checkmk-commits] [tribe29/checkmk] 3cdfd2: Add another missing image

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3cdfd24ead29ce57a5e3b22d160da439786dcc41 https://github.com/tribe29/checkmk/commit/3cdfd24ead29ce57a5e3b22d160da4397… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: A web/htdocs/themes/facelift/images/icon_collapse_arrow.png Log Message: ----------- Add another missing image Change-Id: Ifef3810ce46a5afe9d4429fe8520d28b7f02a233 Commit: 03b07eda939705f61ed07bbbc3d2084756c3eb2a https://github.com/tribe29/checkmk/commit/03b07eda939705f61ed07bbbc3d208475… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M cmk/base/data_sources/_abstract.py M cmk/base/data_sources/snmp.py Log Message: ----------- Formalize missing configuration point in ABCDataSource Make _summary_result() abstract in the ABC and move the implementation to SNMPDataSource. The method was already overridden in AgentDataSource. CMK-4838 Change-Id: Ife5e724322b113a547a87be37b3bd3d5f80536b6 Commit: 6d1428935ec2fcf8b5db5cc742d94e41dfc295d7 https://github.com/tribe29/checkmk/commit/6d1428935ec2fcf8b5db5cc742d94e41d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M cmk/base/data_sources/agent.py M tests/unit/cmk/base/data_sources/test_tcp_data_source.py Log Message: ----------- Extract Summarizer class from AgentDS The AgentDataSource has several responsibilities so that the code is not clear. Here, we extract the summary-related methods from the main class. It is clear that the methods do not have much to do with the DS. Now, we can also see that what gets summarized is not the DS but the AgentSectionContent contained in some attribute of the DS. We shall make this clear in a next patch. CMK-4838 Change-Id: Ib2de63202dd6c7f1e08336e0dbe063363df00db5 Commit: 4d30453552567bc96839798f72bacacdf0972145 https://github.com/tribe29/checkmk/commit/4d30453552567bc96839798f72bacacdf… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M cmk/base/data_sources/agent.py M tests/unit/cmk/base/data_sources/test_tcp_data_source.py Log Message: ----------- Clarify summary object in Agent DS Pass the Optional[AgentSectionContent] to the summarizer as it seems like the object being summarized. We make some trivial methods static. Actually, the remaining non-static methods only use an HostConfig that is not really owned by the Summarizer... All of this may be advantageously replaced with free functions or moved some place it belongs in. CMK-4838 Change-Id: I223f2160a8cd7de4d776e6c129da778e2bf89213 Commit: 34fe2d8beac818cf71f6d3110bc1268a5a0fc052 https://github.com/tribe29/checkmk/commit/34fe2d8beac818cf71f6d3110bc1268a5… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M cmk/base/data_sources/agent.py M tests/unit/cmk/base/data_sources/test_agent.py Log Message: ----------- Extract Parser class from AgentDS This again removes noise from the main class. CMK-4838 Change-Id: I4536cca566c84f846ed9a09070a8a55fe94467ad Commit: e6399a61e538923abeb99f37bbc5aa628f26b007 https://github.com/tribe29/checkmk/commit/e6399a61e538923abeb99f37bbc5aa628… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M cmk/base/data_sources/agent.py Log Message: ----------- Pass more useful args to parser CMK-4838 Change-Id: Ib9d199de9185fe13debbb53ed759c05aad12f64c Commit: fa6e7243c768e3e29d1710dc710352bc0250efc3 https://github.com/tribe29/checkmk/commit/fa6e7243c768e3e29d1710dc710352bc0… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M cmk/base/data_sources/agent.py M cmk/base/ip_lookup.py M tests/unit/cmk/base/data_sources/test_agent.py M tests/unit/cmk/base/test_ip_lookup.py Log Message: ----------- Group IP utils and corresponding tests CMK-4838 Change-Id: I2fbb2334cd4c9b5f529229fef5ff521053fe7ee9 Commit: 3f8ca2eb2768631b17d9124751b75e3b12977051 https://github.com/tribe29/checkmk/commit/3f8ca2eb2768631b17d9124751b75e3b1… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M tests/unit/cmk/base/data_sources/test_agent.py Log Message: ----------- test_agent: whitespace Test classes with classes and shut yapf up. CMK-4838 Change-Id: I3a34bd6e7e97354c634738f5bf0cdcc2901690ee Commit: 1c6788a797cc2516e2ee2b753d6808bac6431a7b https://github.com/tribe29/checkmk/commit/1c6788a797cc2516e2ee2b753d6808bac… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M cmk/base/data_sources/agent.py M tests/unit/cmk/base/data_sources/test_agent.py Log Message: ----------- Demonstrate what the Parser does with unit tests CMK-4838 Change-Id: I0d8ff8dc7ecdc80d804e980efaef44ee8f815e33 Commit: 84fb9befe1f3cef72c25f6aec3d944d018fbaa9a https://github.com/tribe29/checkmk/commit/84fb9befe1f3cef72c25f6aec3d944d01… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-07-13 (Mon, 13 Jul 2020) Changed paths: M cmk/base/data_sources/_abstract.py Log Message: ----------- Whitespace: Unyapfify source code CMK-4838 Change-Id: I0fcd8e57b77a077b7d1140293a3d6553083f4953 Compare: https://github.com/tribe29/checkmk/compare/bfc8099fa20e...84fb9befe1f3