[checkmk-commits] [tribe29/checkmk] 270009: Fix decryption bug in TCP data source

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2700098da8ba2964e2b7afaf6b18f16ab0b50ab6 https://github.com/tribe29/checkmk/commit/2700098da8ba2964e2b7afaf6b18f16ab… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M cmk/base/data_sources/tcp.py Log Message: ----------- Fix decryption bug in TCP data source Decryption could randomly fail in the following scenario: # OpenSSL padds the decrypted data with more than 10 bytes: "...end of decrypted data\x0a\x0a\x0a\x0a\x0a\x0a\x0a\x0a\x0a\x0a" # In Python 3, indexing bytes returns the elements as int, so `b"...\x0a"[-1]` returns `10`. # Calling str on `10` return `"10"`. # `ord()` raises: TypeError: ord() expected a character, but string of length 2 found. This bug most likely originates from the python 2 to 3 conversion. Change-Id: Idf1bc2e9a415936cb36107350a3ee1059fe96731 Commit: 551277848180659d58ee35afb3a7f93cfad29005 https://github.com/tribe29/checkmk/commit/551277848180659d58ee35afb3a7f93cf… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/diagnostics.py M cmk/gui/config.py M cmk/gui/wato/pages/diagnostics.py M tests-py3/integration/cmk/base/test_automations.py M tests-py3/unit/cmk/base/test_unit_automations.py M tests/unit/cmk/gui/test_background_job.py A web/htdocs/themes/classic/images/icon_diagnostics_dump_file.png A web/htdocs/themes/facelift/images/icon_diagnostics_dump_file.png Log Message: ----------- Diagnostics: Add parameters and background job for diagnostic analysis Change-Id: I0235fd736d6defdde95658bab127cab67f052207 Commit: ab2c07a2c1c09ce10548e3ce6f8d9ea0af14b98f https://github.com/tribe29/checkmk/commit/ab2c07a2c1c09ce10548e3ce6f8d9ea0a… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-04-07 (Tue, 07 Apr 2020) Changed paths: M cmk/gui/metrics.py M cmk/gui/plugins/views/perfometers/__init__.py M cmk/gui/plugins/views/wato.py M cmk/gui/plugins/views/webservice.py M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- Some --check-untyped-defs fixes, part 53. Change-Id: Ia0b9c51ca0f33757af0e5e60ac2e831b19975215 Compare: https://github.com/tribe29/checkmk/compare/a3bce12e9113...ab2c07a2c1c0