[checkmk-commits] [tribe29/checkmk] f28b75: REST API: typing improvements

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: f28b7532cb96723b91c81c11d118777942ea1fe3 https://github.com/tribe29/checkmk/commit/f28b7532cb96723b91c81c11d11877794… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/decorators.py M cmk/gui/plugins/openapi/utils.py Log Message: ----------- REST API: typing improvements Change-Id: I674ce7b4edb52973d315c86af8ab753b9d48f806 Commit: 54aeaf54f0ab94998d13408aeca96703e4600074 https://github.com/tribe29/checkmk/commit/54aeaf54f0ab94998d13408aeca96703e… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/wsgi/applications/rest_api.py Log Message: ----------- REST API: fix test for swagger UI Change-Id: I4de53d8af6cc0c0a5ffe33f9c9fc2d0b5a349641 Commit: 70b8a224825f919ef0cc8c8e78062eb4e262fd2b https://github.com/tribe29/checkmk/commit/70b8a224825f919ef0cc8c8e78062eb4e… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/globals.py M cmk/gui/plugins/openapi/restful_objects/decorators.py A cmk/gui/plugins/openapi/restful_objects/permissions.py M cmk/gui/plugins/openapi/restful_objects/response_schemas.py M cmk/gui/utils/logged_in.py M cmk/gui/wsgi/applications/rest_api.py M cmk/gui/wsgi/middleware.py Log Message: ----------- REST API: permission system The following are the goals for this system: * document the necessary permissions on the endpoints * document these permissions for the end-user * ensure that: * the actually used permission are defined and valid * any permission is actually defined * any permission is actually used Any failure will lead to the endpoint terminating. In this scope, from now on, all endpoints must have their permissions defined to be able to work. Change-Id: I1ceeaedc0425f31921237786a6a164b7b5c71a7a Commit: c0018affa472beaa8db74adc590ae321f4a147b8 https://github.com/tribe29/checkmk/commit/c0018affa472beaa8db74adc590ae321f… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/password.py M cmk/gui/watolib/passwords.py Log Message: ----------- REST API: password endpoint authorization Change-Id: Ic868367b0491f13b8395661fa32033a76af6919a Commit: 0583c5d8d460b38fe20028a9b49bfc4a03ff2bdc https://github.com/tribe29/checkmk/commit/0583c5d8d460b38fe20028a9b49bfc4a0… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/decorators.py M cmk/gui/plugins/openapi/restful_objects/permissions.py M cmk/gui/utils/logged_in.py Log Message: ----------- REST API: fix permission system When multiple permissions were required, the system assumed they would be checked at the same time, but in fact they are checked sequentially. So now the system doesn't check exhaustiveness in that case but just verifies that the checked permission is actually declared. Change-Id: I8524e56037bf4f42960cff5ef837c502a460714a Commit: 0f094cd6fbfbcd6a138d9abd5093c2f684f003c8 https://github.com/tribe29/checkmk/commit/0f094cd6fbfbcd6a138d9abd5093c2f68… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/utils/logged_in.py Log Message: ----------- UserContext/SuperUserContext: doc updates Change-Id: I2d5a820ef1d2a73ff201c5d6fddfcb9863d186f1 Commit: 848030e07f7943084e76933ceb1ce32934856f99 https://github.com/tribe29/checkmk/commit/848030e07f7943084e76933ceb1ce3293… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- testing: remove print debug stmt Change-Id: Id695518bb19089b4bd8d63fa8b6476818747b3d0 Commit: b4c52acbaa7ad08457f622925e12023fcccb5a7d https://github.com/tribe29/checkmk/commit/b4c52acbaa7ad08457f622925e12023fc… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- tests: add fixtures to run test as users/superusers * these fixtures also handle loading the config Change-Id: Id22dd6d96c8b4b8ca156564302bd8a590b590617 Commit: 5cdc679c85a6bcf7e686b54a02cab37df9f493ca https://github.com/tribe29/checkmk/commit/5cdc679c85a6bcf7e686b54a02cab37df… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/permissions.py Log Message: ----------- permission system: add support for optional permissions Change-Id: I5c480a01c8418ac7ca625fdef37194b6418a14dc Commit: 2dde059689fcc943fc521cd4bece50b757f16c78 https://github.com/tribe29/checkmk/commit/2dde059689fcc943fc521cd4bece50b75… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/utils/logged_in.py Log Message: ----------- permission system: exception formatting Change-Id: Ib33f9936e84721fe30b56fdecad37c419d9bca71 Commit: 2118040548b55ba45b4fbd30009590aaa1c865d3 https://github.com/tribe29/checkmk/commit/2118040548b55ba45b4fbd30009590aaa… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/permissions.py Log Message: ----------- permission system: rename may to has_permission Change-Id: I34489963f876477805a47006402beb29fe22bb5a Commit: 3f5d6c213b17000345d28e4cb2ffe4869bd2b147 https://github.com/tribe29/checkmk/commit/3f5d6c213b17000345d28e4cb2ffe4869… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/decorators.py Log Message: ----------- permission system: better document nested permissions Change-Id: Ia8ddd6d92fd9bcbd020f882ffe9db5729cd0ef04 Commit: 6b3de3fa1f57ea20beb732321aac37fd967be99e https://github.com/tribe29/checkmk/commit/6b3de3fa1f57ea20beb732321aac37fd9… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/decorators.py M cmk/gui/utils/logged_in.py Log Message: ----------- REST API: allow suppressing of permission usage tracking * this is a workaround due to a long list of permissions under the dashboard.* namespace, which are checked at unopportune places for our endpoints. * to circumvent this issue, we don't track those permissions (close our eyes for reality) and require the permissions manually in the endpoint. Change-Id: Ica99c21f5657514abf623d9a614bd777054fa681 Commit: 1e01418f15edf400480cd95f2034b2b267fe4e1c https://github.com/tribe29/checkmk/commit/1e01418f15edf400480cd95f2034b2b26… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/contact_group_config.py M cmk/gui/plugins/openapi/endpoints/host_group_config.py M cmk/gui/plugins/openapi/endpoints/service_group_config.py M cmk/gui/plugins/openapi/endpoints/utils.py M cmk/gui/watolib/groups.py M tests/testlib/users.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_user.py M tests/unit/cmk/gui/utils/test_logged_in.py M tests/unit/cmk/gui/watolib/test_groups.py Log Message: ----------- REST API: group endpoints authorization * password endpoints now need "wato.groups", due to the link to contact-groups * all groups need "wato.groups" to be edited/acessed Change-Id: I977cde5e64826578c97761091c62b423b91575b8 Commit: c9fed82683453ce8f4b184138003c0d63fdb1fea https://github.com/tribe29/checkmk/commit/c9fed82683453ce8f4b184138003c0d63… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/certs.py Log Message: ----------- REST API: certificate endpoints authorization Change-Id: I9b9639a436db62aca2ee17ebc9bc60d0a46df840 Commit: 7fa22988b82a19ebf5849c8c2be727fbcbb7369d https://github.com/tribe29/checkmk/commit/7fa22988b82a19ebf5849c8c2be727fbc… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/folder_config.py M cmk/gui/plugins/openapi/endpoints/host_config.py M cmk/gui/plugins/openapi/endpoints/host_internal.py M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- REST API: hosts and folder authorization Change-Id: Icfb92acb15eb5821899f31afa9adb0bd2d1293fc Commit: 4f96795f29ee5bccd004c7f40fad31d0d94fae4d https://github.com/tribe29/checkmk/commit/4f96795f29ee5bccd004c7f40fad31d0d… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/rule/__init__.py Log Message: ----------- REST API: rules authorization Change-Id: I87b8fd17ff9df2511454d5bdb3f5d6291354890c Commit: e2e1eb489e0911e23b6379866d2f672faa29c78e https://github.com/tribe29/checkmk/commit/e2e1eb489e0911e23b6379866d2f672fa… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/ruleset/__init__.py Log Message: ----------- REST API: rulesets authorization Change-Id: I04a9761d5b73a9165fcb77e5d1dcd6627fd423a7 Commit: 2b65af1a52ae3f723fb649848098a8675dd7b979 https://github.com/tribe29/checkmk/commit/2b65af1a52ae3f723fb649848098a8675… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/decorators.py Log Message: ----------- permission system: clarify error message Change-Id: I4d5d4b1feb8efef0b645dbac829df0f20b8c9942 Commit: 551d9f72937ab2e9251003a667e05fb17dbf7ad6 https://github.com/tribe29/checkmk/commit/551d9f72937ab2e9251003a667e05fb17… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/host_tag.py M cmk/gui/plugins/openapi/endpoints/password.py M cmk/gui/plugins/openapi/endpoints/user_config.py Log Message: ----------- REST API: cleanup of calls to problem() Change-Id: I9d021ae1d88f73e0e8098257ec652b143a2ce4e8 Commit: a6929e4cb67f7809d09d823c208d048a52282b6b https://github.com/tribe29/checkmk/commit/a6929e4cb67f7809d09d823c208d048a5… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/service_discovery.py M cmk/gui/watolib/services.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_service_discovery.py Log Message: ----------- REST API: service discovery authorization * add permission declarations * remove legacy code path that needed extra permissions Change-Id: I569b4b4ed1f76d9cdcbbaded3f68b35b82e49ba5 Commit: c171d5189234faf7139ab8691a760531e4723617 https://github.com/tribe29/checkmk/commit/c171d5189234faf7139ab8691a760531e… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/restful_objects/type_defs.py M cmk/gui/watolib/automations.py A tests/unit/cmk/gui/plugins/openapi/test_openapi_dcd.py Log Message: ----------- API: addition of dcd fetch phase one result endpoint Change-Id: Ic4debbcd9877c47db8d08bcd0cebf5ee35ed9253 Commit: 08998283fee9a315e3b5249296c022d233ea0681 https://github.com/tribe29/checkmk/commit/08998283fee9a315e3b5249296c022d23… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/host_config.py Log Message: ----------- FIX API host_config: change string to f-string for faulty_attributes Change-Id: Ife03182cd36ef46b597d1dd18c603a8eb3c5fe11 Commit: 1aca30bcf78c941aa182c80deba29a8e97cbdc48 https://github.com/tribe29/checkmk/commit/1aca30bcf78c941aa182c80deba29a8e9… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/watolib/automations.py M cmk/utils/type_defs/__init__.py A cmk/utils/type_defs/automations.py Log Message: ----------- web_api: replacing web_api by rest_api for execute_remote_automation call Change-Id: I0bbe32a5ecf0e01c52112b62b43998de1cf44df4 Commit: c2c244f5e6fbe053155cabaef4827b053660eb45 https://github.com/tribe29/checkmk/commit/c2c244f5e6fbe053155cabaef4827b053… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/rule/__init__.py Log Message: ----------- REST API: refactor _get_rule_by_id and _serialize_rule Change-Id: I6aacdd9d4b51356acfc16b0666a779b896582811 Commit: ed29f6bc339a61ba71a44accdb5d4363e0d81df2 https://github.com/tribe29/checkmk/commit/ed29f6bc339a61ba71a44accdb5d4363e… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: A .werks/13930 M cmk/gui/plugins/openapi/endpoints/rule/__init__.py M cmk/gui/plugins/openapi/endpoints/rule/fields.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_rules.py M tests/unit/cmk/utils/test_werks.py Log Message: ----------- 13930 FIX adjust Rule response format in REST API The response of the Rule object has been changed from singular to plural in some cases. Concretely, the following fields have been changed: * host_tag -> host_tags * host_label -> host_labels * service_label -> service_labels If you use statically typed language, you may have to recompile your auto generated API client. Change-Id: I391ff1672790fc2feeeaacc04aaa9b70ddebec71 Commit: 2e0338a4ae54522603a7851bc84ad39e398ee48d https://github.com/tribe29/checkmk/commit/2e0338a4ae54522603a7851bc84ad39e3… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/rule/__init__.py M cmk/gui/plugins/openapi/endpoints/rule/fields.py M cmk/gui/watolib/rulesets.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_rules.py Log Message: ----------- REST API: add move rule endpoint Change-Id: I183a8926ac8a8d5b66869f9c4699e8f40e5b723b Compare: https://github.com/tribe29/checkmk/compare/b2b0cbc1bd74...2e0338a4ae54