[checkmk-commits] Add fix for icon default overrides

Module: check_mk Branch: master Commit: a64d7da09c256ea16e1b8874b7b4960807d30759 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a64d7da09c256e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jan 10 17:17:36 2019 +0100 Add fix for icon default overrides Change-Id: I5092d0bd09f62e32e32b49b9cee28c099d7a7d18 --- cmk/gui/plugins/views/icons/utils.py | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/cmk/gui/plugins/views/icons/utils.py b/cmk/gui/plugins/views/icons/utils.py index 0d4bcf2..6dbacd9 100644 --- a/cmk/gui/plugins/views/icons/utils.py +++ b/cmk/gui/plugins/views/icons/utils.py @@ -54,6 +54,8 @@ class PermissionSectionIconsAndActions(PermissionSection): class Icon(object): __metaclass__ = abc.ABCMeta + _custom_toplevel = None # type: Optional[bool] + _custom_sort_index = None # type: Optional[int] @classmethod def type(cls): @@ -61,6 +63,16 @@ class Icon(object): return "icon" @classmethod + def override_toplevel(cls, toplevel): + # type: (bool) -> None + cls._custom_toplevel = toplevel + + @classmethod + def override_sort_index(cls, sort_index): + # type: (int) -> None + cls._custom_sort_index = sort_index + + @classmethod @abc.abstractmethod def ident(cls): # type: () -> str @@ -101,11 +113,6 @@ class Icon(object): # type: () -> int return 30 - def __init__(self): - super(Icon, self).__init__() - self._custom_toplevel = None # type: Optional[bool] - self._custom_sort_index = None # type: Optional[int] - def toplevel(self): # type: () -> bool if self._custom_toplevel is not None: @@ -118,14 +125,6 @@ class Icon(object): return self._custom_sort_index return self.default_sort_index() - def override_toplevel(self, toplevel): - # type: (bool) -> None - self._custom_toplevel = toplevel - - def override_sort_index(self, sort_index): - # type: (int) -> None - self._custom_sort_index = sort_index - class IconRegistry(cmk.utils.plugin_registry.ClassRegistry): def plugin_base_class(self):