[checkmk-commits] [tribe29/checkmk] 182cc9: Wrap crash report functionality into ABCCrashReport

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 182cc980bcf8b5674454dec947a3648d8d713053 https://github.com/tribe29/checkmk/commit/182cc980bcf8b5674454dec947a3648d8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/gui/crash_reporting.py M cmk/utils/crash_reporting.py M cmk/utils/paths.py M cmk_base/crash_reporting.py M tests/unit/cmk/utils/test_crash_reporting.py Log Message: ----------- Wrap crash report functionality into ABCCrashReport * Made helper functions module local functions * Fix some potential bugs uncovered by mypy Change-Id: I5878c41e723ff2a04e6f26bfebeba34444e68dc3 Commit: 4864b6335017f2d725b0abb75183dac9a9124f1b https://github.com/tribe29/checkmk/commit/4864b6335017f2d725b0abb75183dac9a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/utils/crash_reporting.py Log Message: ----------- Add some type annotations Change-Id: I00d0816f3e944f92c409456906a826bafe68bcd2 Commit: 05a31d4ec56febaae1869077fe84b961053127a8 https://github.com/tribe29/checkmk/commit/05a31d4ec56febaae1869077fe84b9610… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M bin/check_mk M cmk_base/crash_reporting.py M tests/testlib/__init__.py M tests/unit/cmk/utils/test_crash_reporting.py A tests/unit/cmk_base/test_base_crash_reporting.py Log Message: ----------- Start applying new crash reporting * Create first component specific crash report: CMKBaseCrashReport * Add it as exception handler to the "cmk" command * Crashes are stored below var/check_mk/crashes/base/ * Added unit tests for generic crash report functionality and the base crash report Change-Id: Ieebb6ded4b34a1f3c681d2cc3fd603d284be2e5e Commit: 20edd5b213d15663d06c8a72e7361b9545117202 https://github.com/tribe29/checkmk/commit/20edd5b213d15663d06c8a72e7361b954… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/utils/crash_reporting.py Log Message: ----------- Crashes: Change IO to pathlib Change-Id: Ibe505d767999d80e1d455aa2a5313221ea890625 Commit: 2a389b9e1762984110f5ce018ab78de8a887273b https://github.com/tribe29/checkmk/commit/2a389b9e1762984110f5ce018ab78de8a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M tests/unit/cmk_base/test_base_crash_reporting.py Log Message: ----------- Add some unit tests for saving and packing the crashes Change-Id: I1dc4d7d227bcf5fa945f80cdedd3a2dfeba1201f Commit: c1f0d5134733cb1721be2057dbca57404a378b9c https://github.com/tribe29/checkmk/commit/c1f0d5134733cb1721be2057dbca57404… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/utils/crash_reporting.py M cmk_base/crash_reporting.py M tests/unit/cmk_base/test_base_crash_reporting.py Log Message: ----------- Register crash report types with registry All possible crash report types are now registered with the registry cmk.utils.crash_reporting.crash_report_registry Change-Id: I34c38f226df53bd17051a68139a1a4cc7a2bba7b Commit: a639e4408eb41889baf5222e60c9449feeec555e https://github.com/tribe29/checkmk/commit/a639e4408eb41889baf5222e60c9449fe… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M bin/check_mk M cmk/utils/crash_reporting.py M cmk_base/crash_reporting.py M tests/unit/cmk_base/test_base_crash_reporting.py Log Message: ----------- Move crash report persistance to dedicated class The CrashReportStore is now responsible for loading/saving the ABCCrashReport objects in the local site. Change-Id: Ifb3078797684deffa0fa05e9176232a5a7f28361 Commit: 2f3c50239c23d7aac53eeec68545e8ca902d3aaa https://github.com/tribe29/checkmk/commit/2f3c50239c23d7aac53eeec68545e8ca9… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/utils/crash_reporting.py M tests/unit/cmk_base/test_base_crash_reporting.py Log Message: ----------- Cleanup loading crash reports from crash directory * The store loading of crash reports can now load crash reports by their crash directory * The crash_info data structure is now mandatory which reduces some special cases in ABCCrashReport. Change-Id: Ib6240525f54854a2c410bd5730806bddc9842c99 Commit: 1b75e1d8e054bb52e6895574f94c90dc3721e32e https://github.com/tribe29/checkmk/commit/1b75e1d8e054bb52e6895574f94c90dc3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk_base/checking.py M cmk_base/crash_reporting.py M cmk_base/decorator.py M tests/unit/cmk_base/test_base_crash_reporting.py Log Message: ----------- Refactor check crash reporting to base on ABCCrashReport The check crashes are now stored in the crash directory for later processing. The crash reports are still appended to the long output for submission for the moment. This will be changed once the new crash transport is ready. Change-Id: I6bdd1f2133f30195ccbfd924ff5bd12731b3e014 Commit: 1400566fa4c94ae885d949929d57579ce6e09249 https://github.com/tribe29/checkmk/commit/1400566fa4c94ae885d949929d57579ce… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk_base/crash_reporting.py M tests/testlib/__init__.py M tests/unit/cmk_base/test_base_crash_reporting.py Log Message: ----------- Refactor snmp/agent data read to pathlib; add some tests Change-Id: I591c00ef6d84a2801b1a070786c788f96ca5e9b9 Commit: 12c03ae10b064e5d88515b574e145778801381bc https://github.com/tribe29/checkmk/commit/12c03ae10b064e5d88515b574e1457788… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: A cmk/ec/crash_reporting.py M cmk/ec/main.py A tests/unit/cmk/ec/test_ec_crash_reporting.py M tests/unit/cmk_base/test_base_crash_reporting.py Log Message: ----------- Add crash reporting to different places The most important places now use the new crash reporting mechanism: Event Console, Liveproxyd, Notification Spooler, Dynamic configuration daemon. Change-Id: Ib0b9e8c0064c004fe076d74bdeac06727a9ecd1b Commit: 537e05612b23e75b7de671f497035dba5becf56d https://github.com/tribe29/checkmk/commit/537e05612b23e75b7de671f497035dba5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/gui/crash_reporting.py Log Message: ----------- GUI crash handling Change-Id: I94d97d7f9e73887201f484c627dedb2417748067 Commit: f5a389d16d3061ceddec420092bedc1b8fe4a245 https://github.com/tribe29/checkmk/commit/f5a389d16d3061ceddec420092bedc1b8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: A cmk/gui/plugins/views/crash_reporting.py M cmk/gui/plugins/visuals/infos.py M cmk/utils/crash_reporting.py Log Message: ----------- Crash reporting views Prepare GUI for working with the new crash reports. This commits makes it possible to add views which can show crash report information. For the moment these views can only display site local crash reports, until the data source can be switched to Livestatus to gather the crash information. Change-Id: I3408e52aa2523caf78f1fe54fa37bb5ea31d76ed Commit: 04851d7b805fbd4aff1203d1b650c1a827d90a08 https://github.com/tribe29/checkmk/commit/04851d7b805fbd4aff1203d1b650c1a82… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/gui/plugins/views/builtin.py M cmk/gui/plugins/views/sorters.py M tests/unit/cmk/gui/test_gui_config.py Log Message: ----------- Add crash report list view Change-Id: I069db7c238089c960aca5895050a5fde12ba11e4 Commit: 30715da5410c8612c7d5f8c2d3dbe2d2499e721f https://github.com/tribe29/checkmk/commit/30715da5410c8612c7d5f8c2d3dbe2d24… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/gui/crash_reporting.py M cmk/gui/plugins/views/icons/builtin.py M cmk/utils/crash_reporting.py M cmk_base/crash_reporting.py A tests/unit/cmk/gui/test_gui_crash_reporting.py M tests/unit/cmk/gui/test_pages.py M tests/unit/cmk_base/test_base_crash_reporting.py M web/app/index.wsgi Log Message: ----------- New crash report detail page * The differences between GUI and check crashes has been cleaned up. All types of crash reports are now first stored in the sites local crash report store and can be loaded from there. * There is a dedicated "crash detail" page now, which can display all kind of crash reports on one page and can be used to submit the crash report. This page is opened with the crash report ID and the site ID as parameter. * Check crash dumps are not transported via the service long output anymore. The output now only contains a reference to the related crash ID. * Moved crash report packing to the GUI, because it is only needed there for submission to the Checkmk developers * Several cleanups on the way Future: * Currently the new page can only display crashes of the local site. Once the livestatus table for the new crash reports is ready, the temporary functions can be replaced by livestatus lookups. Change-Id: Ie996a669dd2e4b752cb24dabf90b528c789f356f Commit: 2624bacbfe6469b895dfdd0f2ba7671a52e62fc1 https://github.com/tribe29/checkmk/commit/2624bacbfe6469b895dfdd0f2ba7671a5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/utils/crash_reporting.py M cmk_base/crash_reporting.py Log Message: ----------- Identify crash reports by unique ID To make it possible to reference crashes without race conditions on the local site, all crashes are now referenced by a unique ID. Change-Id: I014b29cb51b6e86577f891635e7bcb885d0b14d9 Commit: 2944926fe2ee1982d1c49d30cddca40e490a9668 https://github.com/tribe29/checkmk/commit/2944926fe2ee1982d1c49d30cddca40e4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/utils/crash_reporting.py M tests/unit/cmk/utils/test_crash_reporting.py Log Message: ----------- Add simple crash report cleanup mechanism For each crash type (component) the most recent 20 crashes are kept by the store. When a new crash is stored, exceeding the number of maximum crashes, the oldest crash is removed. Change-Id: I48fcbd6c26963647f54c6c618866fc8b073a2921 Commit: c60fd39c6777a65372689b4002826fbc9db1f78f https://github.com/tribe29/checkmk/commit/c60fd39c6777a65372689b4002826fbc9… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/gui/crash_reporting.py Log Message: ----------- Cleaned up crash type specific rendering * Moved specific rendering of context buttons and page elements to a dedicated type specific renderer class * Added a generic renderer to be used to show detail information that is available for crash types that have no specific renderer. Change-Id: If3de4b2083bafcbbf37654c6d194e8f6572c1554 Commit: 335299a364039d75169cefe05328f4dafc380c76 https://github.com/tribe29/checkmk/commit/335299a364039d75169cefe05328f4daf… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2019-11-08 (Fri, 08 Nov 2019) Changed paths: M cmk/gui/crash_reporting.py M cmk/gui/plugins/config/base.py M cmk/gui/plugins/wato/check_mk_configuration.py M tests/unit/cmk/gui/watolib/test_watolib.py Log Message: ----------- Crash report target URL is now configurable You may change the crash report target URL for some reason. The server you point the URL to will have to be able to deal with the HTTP calls Checkmk makes to send the crash reports. Change-Id: I86abc7d82c10de02f6bcc4f4183d41ba920507b2 Compare: https://github.com/tribe29/checkmk/compare/a1e4d06abbfe...335299a36403