[checkmk-commits] [tribe29/checkmk] e901d5: Fixed logging in cmk-update-config, part 2.

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e901d5ed847541844f2f0a970b31f3e8410ed747 https://github.com/tribe29/checkmk/commit/e901d5ed847541844f2f0a970b31f3e84… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2019-08-27 (Tue, 27 Aug 2019) Changed paths: M cmk/update_config.py M tests/unit/cmk/test_update_config.py Log Message: ----------- Fixed logging in cmk-update-config, part 2. Change-Id: I94611c607cfd0f48ecc042f34eee921b5fee3117 Commit: 4b2928cbd139c960ce2d2c8b56be00e482aa5ad9 https://github.com/tribe29/checkmk/commit/4b2928cbd139c960ce2d2c8b56be00e48… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2019-08-27 (Tue, 27 Aug 2019) Changed paths: M cmk_base/core_config.py M cmk_base/core_nagios.py Log Message: ----------- Refactoring: Move funny special cases to the call sites. Structurally, this is inversion of control, a.k.a. the Hollywood Principle: "Don't call us, we call you!" If we had classes here at hand (which we really should), this refactoring would be: https://refactoring.com/catalog/replaceConditionalWithPolymorphism.html We already *have* a MonitoringCore class where the additional three methods should live, but threading through the right instance is currently a bit tricky because of several layers of "interesting" code in between. Without an instance at hand, we simulate it by passing three functions, i.e. we use "poor man's OO" for now. :-) Change-Id: I245b373220e60ae24977af020c4db928e5486f77 Compare: https://github.com/tribe29/checkmk/compare/e01d0a6aba33...4b2928cbd139