[checkmk-commits] [tribe29/checkmk] edea46: New filter scheme: Use an input value instead

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: edea460ed07503fd35a1d9c2755ff075890b1ec2 https://github.com/tribe29/checkmk/commit/edea460ed07503fd35a1d9c2755ff0758… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/availability.py M cmk/gui/bi.py M cmk/gui/mobile.py M cmk/gui/node_visualization.py M cmk/gui/plugins/views/availability.py M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/inventory.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/plugins/visuals/wato.py M cmk/gui/type_defs.py M cmk/gui/valuespec.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py Log Message: ----------- New filter scheme: Use an input value instead Filters will now require their pertinent configuration giving by the FilterHTTPVariables, which are exhaustively constructed by the Filter class using the htmlvars. For the moment update the form and make sure that pylint, mypy, & pytests are happy with the change. Use FilterHeader type, only singular as is alias of string FilterGroupCombo has inactive filters since 2014, never discarded, daring now Extra typing limitations on inventory.get_inventory_attribute output @si Change-Id: Iba01d573827369a289206167b003f641cc04d653 Commit: f98b23d42cbd23ec8016c4bfffdcf594540fc10b https://github.com/tribe29/checkmk/commit/f98b23d42cbd23ec8016c4bfffdcf5945… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/inventory.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/visuals.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py Log Message: ----------- New scheme display fixes where they break Sometimes out of valuespec the input is a None on empty fields and not a filterHTTPVariables display checkboxes and radio buttons are left for next commits Change-Id: I42f17b67ea49100303ee02ea2e1abfcd83d6f5ba Commit: 42e967a5ad48585be0544698a9b8f44d68e397c6 https://github.com/tribe29/checkmk/commit/42e967a5ad48585be0544698a9b8f44d6… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/plugins/visuals/inventory.py Log Message: ----------- New scheme display inventory Change-Id: Ic219031b9a33a57e0198707900508a8d1a213411 Commit: 900dadd6c797290a0ce3a41a5c48600e48a953ea https://github.com/tribe29/checkmk/commit/900dadd6c797290a0ce3a41a5c48600e4… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/inventory.py M cmk/gui/plugins/visuals/utils.py Log Message: ----------- Cleanup Filters that display radio buttons The horizontal option in radio group seems to only influence the mobile GUI. Is it still relevant? It is also not used on all filters although they would profit. Change-Id: I2d04a2614c37d510fcfcbfe4504824093dce52da Commit: 4384ac512910b4d9643901d740b70e04905b01ff https://github.com/tribe29/checkmk/commit/4384ac512910b4d9643901d740b70e049… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/inventory.py Log Message: ----------- Cleanup checkboxes Change-Id: Iaf79ca41e0e2859d519e85d59e3d74d24cc6c420 Commit: 5a29094745ce3164fe0d783f119ab2003ec0568d https://github.com/tribe29/checkmk/commit/5a29094745ce3164fe0d783f119ab2003… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/views.py Log Message: ----------- Remove _get_view_filters which mutates request The change to request is then pushed later down the data processing for a view. Change-Id: Ibec0c2aba0c4a61dc66a815ef43dcbbb5811f2e2 Commit: 5ceceab210acc36a354b27c73e6b419b0bfa66ed https://github.com/tribe29/checkmk/commit/5ceceab210acc36a354b27c73e6b419b0… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/views.py M cmk/gui/visuals.py Log Message: ----------- Filters use the FilterHTTPVariables as input Filterheaders generated from input not html request Keep a backwards compatibility for single_info contexts Change-Id: I34bc767546d94aac0bfd158c8457ce3cbd6bba6f Commit: 805796017a4cb4714af2fb8f4a97f5d85c162618 https://github.com/tribe29/checkmk/commit/805796017a4cb4714af2fb8f4a97f5d85… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/valuespec.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py M web/htdocs/js/modules/utils.js Log Message: ----------- Working filter creation from the side filter menu Discard on page_views the concept of single infos. Filters take the dict of html vars an should thus just use that construct. No need for the single string option. The refresh is not working, no persistence yet. Taking the filter as overwrite, yet when not active return to context merge. Refresh view including _active urlvar is needed because now the context is not "merged" upon spec & vars but taken directly out of the filter menu, which starts from the spec and is changed by user. This makes it completely user controlled. Bug of werk 11759 does not come up because filter value is str_mandatory and now work is directly on the context dict. Change-Id: I44d0c19e4f917d225f1013601c58bb51ef52f941 Commit: 923b680a1a938f5b2e75a190a59fa23b5b13d6df https://github.com/tribe29/checkmk/commit/923b680a1a938f5b2e75a190a59fa23b5… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/bi.py M cmk/gui/node_visualization.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/views.py M cmk/gui/visuals.py Log Message: ----------- Refactor: get_livestatus_filter_headers Move this function to utils and utilize it more often Could not find the reference to the reports graphs filter_table use context not request BI singlehost table use context not the old infoname filter with html.request Change-Id: Ib2c4f60b9db67a9e4b822695d8f7c4645b313dbe Commit: c8db9824ec2725349a2723b4543441f3bb732ecb https://github.com/tribe29/checkmk/commit/c8db9824ec2725349a2723b4543441f3b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/plugins/visuals/wato.py M tests/unit/cmk/gui/test_views.py Log Message: ----------- Multiple WATO folder save and recover Use dual list choice because is a manageable valuespec. The problem with ListOf is that when the page menu filters use "reset" the indexing gets lost. (A bug for another war) Change-Id: Iffb608417b2a8fad4d0c946515754f9d86756fb8 Commit: d5d7ab50d0f443f47f2a20b8679f1eaf564f2542 https://github.com/tribe29/checkmk/commit/d5d7ab50d0f443f47f2a20b8679f1eaf5… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/plugins/visuals/wato.py M cmk/gui/visuals.py Log Message: ----------- Filter heading info to use value instead SUP-6284 Change-Id: Ia59aa81477e43dc65bc6ebf1157e41702f41b008 Commit: f79a0250ddcaeb395d3ab87ae422e23cf2a0bfe3 https://github.com/tribe29/checkmk/commit/f79a0250ddcaeb395d3ab87ae422e23cf… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/dashboard.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/dashboard/view.py M tests/unit/cmk/gui/test_dashboard.py Log Message: ----------- Dashboards use context dict instead of request on cmk.gui.dashboard._render_dashlet_content there was an additional loading of context var, which I could not longer find a use for. View Dashlet that seems to use those variable still works correctly in my opinion. Linked views dashlet take the linked view filter configuration at the highest priority of context when merged. Fix bug, problem dashboard is a graph and has infos=host&service like all graphs. It is a very fixed combined graph dashboard, should it merge filter from the page menu? Currently it doesn't. Change-Id: I49717bfd365abde74138ee582b8598f89b78bad7 Commit: 12efe354ec41e327f8d26d8256019ab75aca89c6 https://github.com/tribe29/checkmk/commit/12efe354ec41e327f8d26d8256019ab75… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/dashboard.py M cmk/gui/mobile.py M cmk/gui/plugins/dashboard/graph.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/type_defs.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/plugins/views/test_row_table.py M tests/unit/cmk/gui/plugins/visuals/test_visuals_utils.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- Simplify VisualContext type, remove single_info The new design for filters uses only the full filter variables, which is the multi_info dict. Dashboard: performance graphs correctly get context info Errors on missing info must be handled by the same _render_dashlet function, which raises the warning on missing context instead of _render_dashlet_content which raises the error after livestatus failure. Custom graphs don't rely on the standard graph infos: host & service, because they don't filter on context. The dashlet crashed because VisualFilters queries all filters on the infos, thus it still needs to match the default host & service infos. Reports: Still use get_context_from_uri_var Unlike views, reports can have a larger context than a view matching several datasources. In this case when importing from a view it makes little sense to use the filter menu valuespec, because datasource info gets lost. Just assume that the url filters are the direct recent filters. They still hold the least priority, as report context wins in precedence. Finally, default view filters don't get transferred to report, that was always the case with "Export: this view as pdf". Change-Id: I27b7b9788838abd4ef5147736974982defcbccaa Commit: 198e071ad850770ac6af00a76f6dc0bf3c2798c4 https://github.com/tribe29/checkmk/commit/198e071ad850770ac6af00a76f6dc0bf3… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/bi.py M cmk/gui/plugins/views/bi.py M cmk/gui/plugins/visuals/filters.py Log Message: ----------- Update BI filters to new filter scheme Methods from BI filters like selected_group & service_spec where moved out to their relevant use place in compute_bi_aggregation_filter, because then the conform to the basic methods of Filter, that are required on the function signature by mypy. Change-Id: I4c4a43b787d85b372de4ae5439ad93ecd8b64bfc Commit: 24770402e374536415aa31ccce8a2a7f08bf5df8 https://github.com/tribe29/checkmk/commit/24770402e374536415aa31ccce8a2a7f0… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M cmk/gui/plugins/views/utils.py M cmk/gui/views.py Log Message: ----------- FIX linked_views_url_to have active filters fixed linked urls and multi context report export This is a bad solution, too much code repetition to pass active filters. It should maybe be part of the makeuri. The translation of filters also shows how weak the single_info is on the url_vars. There is a difference on the filter ident and the filter_html_var. Both need to be translated. There is also a KeyError exception, which I believe under the correct translations should not be required. It should not be possible from out side to create linked views that would still be missing some context. Change-Id: I1d475b87cdcbd4aae33a4a43e65d6b2bdfa9fb18 Commit: 4616c643bfd0b16dfbe3c7732943f82aea7c762a https://github.com/tribe29/checkmk/commit/4616c643bfd0b16dfbe3c7732943f82ae… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-07-22 (Thu, 22 Jul 2021) Changed paths: M agents/check_mk_agent.aix M agents/check_mk_agent.freebsd M agents/check_mk_agent.linux M agents/check_mk_agent.openwrt M agents/check_mk_agent.solaris Log Message: ----------- check_mk_agents: bundle sections Change-Id: I6c17b9abe96c75040858419b74769df0f9eb61f3 Compare: https://github.com/tribe29/checkmk/compare/450099989f99...4616c643bfd0