[checkmk-commits] [tribe29/checkmk] 74e4e8: Introduce main and mega menu infrastructure

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 74e4e8eab526fa0a55928e60da4ee69439e6001f https://github.com/tribe29/checkmk/commit/74e4e8eab526fa0a55928e60da4ee6943… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/main_menu.py M cmk/gui/plugins/main_menu/utils.py Log Message: ----------- Introduce main and mega menu infrastructure This mainly introduces the needed registries and renderers. It is not usable at the moment, but will be in the near future. Change-Id: Ib95e920b44416c5f9351521019991ee902467a3d Commit: 83e17b8009cc74b03fceaef0c8d1c24ac1be12e4 https://github.com/tribe29/checkmk/commit/83e17b8009cc74b03fceaef0c8d1c24ac… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/plugins/wato/__init__.py M cmk/gui/plugins/wato/background_job.py M cmk/gui/plugins/wato/bi.py M cmk/gui/plugins/wato/builtin_modules.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/plugins/wato/utils/main_menu.py M cmk/gui/wato/mkeventd.py Log Message: ----------- Introduce topics for WATO main modules Change-Id: Id4a64aa55c805395150b65935b3ba7e434d38d00 Commit: 71c3c918a3b9585ed50588aa2ddd63ded977dc90 https://github.com/tribe29/checkmk/commit/71c3c918a3b9585ed50588aa2ddd63ded… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/plugins/sidebar/wato.py M cmk/gui/wato/__init__.py Log Message: ----------- Cleanup get_modules from cmk.gui.wato namespace Change-Id: I1faf5f575bcb80711841cdf488f3112468058481 Commit: cfad573d236ed003fc0e381076e7f96a4a0a76cd https://github.com/tribe29/checkmk/commit/cfad573d236ed003fc0e381076e7f96a4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/valuespec.py M cmk/gui/views.py M package-lock.json Log Message: ----------- Make icon selector able to select theme builtin icons This is needed for the visuals / page type topics since the builtin topics use builtin icons and the user should be able to clone these and modify them while keep using the builtin icons. Change-Id: I5549b48b7b1f43a8b85b54c47235ff1201d2c47f Commit: 357adc0a881eba23b513a79e3cb9de6441939f9f https://github.com/tribe29/checkmk/commit/357adc0a881eba23b513a79e3cb9de644… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/visuals.py M tests/unit/cmk/gui/test_gui_config.py M tests/unit/cmk/gui/test_pages.py A web/htdocs/themes/facelift/images/icon_new_pagetype_topic.png A web/htdocs/themes/facelift/images/icon_pagetype_topic.png A web/htdocs/themes/facelift/images/icon_pagetype_topics.png Log Message: ----------- Add topic management for visuals / page types The topics are needed to have a clean way of structuring our navigation. It will also give the users the option to customize the navigation. Change-Id: I4b7017e18a40f195203bf41a833431c0920d3719 Commit: 238aee36a83df8b9e9643834f18946abde7e4c60 https://github.com/tribe29/checkmk/commit/238aee36a83df8b9e9643834f18946abd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: A web/htdocs/themes/facelift/images/icon_topic_administration.png A web/htdocs/themes/facelift/images/icon_topic_advanced_monitoring.png A web/htdocs/themes/facelift/images/icon_topic_agents.png A web/htdocs/themes/facelift/images/icon_topic_analyze.png A web/htdocs/themes/facelift/images/icon_topic_applications.png A web/htdocs/themes/facelift/images/icon_topic_events.png A web/htdocs/themes/facelift/images/icon_topic_history.png A web/htdocs/themes/facelift/images/icon_topic_inventory.png A web/htdocs/themes/facelift/images/icon_topic_monitoring.png A web/htdocs/themes/facelift/images/icon_topic_operating.png A web/htdocs/themes/facelift/images/icon_topic_overview.png A web/htdocs/themes/facelift/images/icon_topic_profile.png A web/htdocs/themes/facelift/images/icon_topic_site.png A web/htdocs/themes/facelift/images/icon_topic_unknown.png A web/htdocs/themes/facelift/images/icon_topic_users.png Log Message: ----------- Add topic icons Change-Id: I080491bedc1369286ed658ac7913be8c03951dd0 Commit: 6b31d1467d90edfad889cecfba2593ba077552d9 https://github.com/tribe29/checkmk/commit/6b31d1467d90edfad889cecfba2593ba0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/visuals.py M cmk/update_config.py Log Message: ----------- Add topic migration for custom visuals This affects views, reports, dashboards, custom graphs, graph collections and forecast graphs. In previous versions the topic of these definitions was just a plain text field which allowed the user to enter a topic which was then used to structure the definitions in the navigation. The new navigation requires an unique ID, a title, icon and sort index. To be able to deal with custom definitions. With this migration logic we load all custom definitions from the site and migrate them to the new mechanic. This is done by first searching for existing builtin topics that match the topic, then referencing it or creating a new topic with the same owner as the custom definition. The custom definitions will then reference to the topics. This migration is done during site update. All updates will be made before the GUI is loaded. Change-Id: I8cb61c90e5e04e1e23778165ccfbef3e0a5c377a Commit: 7c67c5aaee6708c9ae7b3dc6879615728fe3054e https://github.com/tribe29/checkmk/commit/7c67c5aaee6708c9ae7b3dc6879615728… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/visuals.py Log Message: ----------- Topics need to be choosen via dropdown now Change-Id: Id3dd104879f38c6bbd05b058d76f7caf35ed8153 Commit: e93f9b653ceaf6608424ee0c5ed617b4aaaeffab https://github.com/tribe29/checkmk/commit/e93f9b653ceaf6608424ee0c5ed617b4a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/plugins/sidebar/views.py Log Message: ----------- Use titles from topic definitions in views snapin Change-Id: I7f8ea2bdc5120235ce7a8c1b43feca4a295937b2 Commit: 16bd1ea0854e474a958bf04d19ad541495ce0e11 https://github.com/tribe29/checkmk/commit/16bd1ea0854e474a958bf04d19ad54149… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/plugins/sidebar/views.py Log Message: ----------- Fix view snapin topic toggle on equal toggles differing in ending number Change-Id: I7755ae995cec9e8081717804f2c7cdf6b8c3881d Commit: e31f9fa45319f6b1210f0147f082ddd4ba26f0ab https://github.com/tribe29/checkmk/commit/e31f9fa45319f6b1210f0147f082ddd4b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/__init__.py M cmk/gui/plugins/sidebar/dashboards.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/plugins/sidebar/views.py M cmk/gui/plugins/sidebar/wato.py M cmk/gui/sidebar.py Log Message: ----------- Refactor visual menu rendering This affects the dashboards, views and reports snapin. Prepare for a cleaner and more generic menu rendering logic involving a topic level and a list of items. The same structure will be used by our upcoming mega menus. For this reason it makes sense to clean it up before. Change-Id: I80b2ba52e43db260caaf0f0d1b8bd00f01a0e55c Commit: bfde006543ba2fe0d5ef793fe3b503b5d62d3b8b https://github.com/tribe29/checkmk/commit/bfde006543ba2fe0d5ef793fe3b503b5d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/visuals.py Log Message: ----------- Add sort index to visuals Since we want the single menu items to be manually sortable in a way which works with custom elements, we need to make this attribute configurable individually for each element. Change-Id: I7892fffd0f78061772f09f1a25e7514cc0294af4 Commit: ab9d7d6256ace73faac044ac123830cb373a8ee2 https://github.com/tribe29/checkmk/commit/ab9d7d6256ace73faac044ac123830cb3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/visuals.py Log Message: ----------- Add basic / advanced toggle to visuals This will be used by the mega menus. Change-Id: I933a744db6579e4572ae7466708bae7134886f62 Commit: 6adf5e77a6b84f52648227ecfd91670605078a8f https://github.com/tribe29/checkmk/commit/6adf5e77a6b84f52648227ecfd9167060… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/plugins/dashboard/builtin.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/plugins/views/builtin.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/views/mkeventd.py M tests/unit/cmk/gui/test_gui_config.py Log Message: ----------- Monitoring: Add new topics + items for navigation * Add needed builtin visual topics * Apply topics and sort index to visuals * Remove top level views that are not part of the navigation anymore Change-Id: I97df635c618e67cecc263148a0277f822d980010 Commit: bb4f0a3674fe3a593b1f094b7e86359b2206f3f6 https://github.com/tribe29/checkmk/commit/bb4f0a3674fe3a593b1f094b7e86359b2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/plugins/sidebar/views.py M cmk/gui/visuals.py Log Message: ----------- Add optional icon_name attribute to menu topics and items Change-Id: I18ef28aebec3cb0a73dc928fa9d427f1d34ca779 Commit: 8a7ff91ea0e858813f2dbec4868ba2838895ae1c https://github.com/tribe29/checkmk/commit/8a7ff91ea0e858813f2dbec4868ba2838… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/gui/plugins/sidebar/utils.py M cmk/gui/plugins/sidebar/wato.py M web/htdocs/themes/facelift/scss/_sidebar.scss Log Message: ----------- Use topic menu logic for WATO navigation snapins * Add topics to configuration snapin * Use the topics defined for the WATO main modules Change-Id: I7e9349aaea6fe7d94f9b02ced0f641c1d44ef8b6 Commit: 8577adb2065b7680c309345fc481b989be0f720e https://github.com/tribe29/checkmk/commit/8577adb2065b7680c309345fc481b989b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/ec/main.py Log Message: ----------- Untangle event limit computations Change-Id: I33112df165d04796b50261da0a99fc257e8b0fbd Commit: bf5b15993d2e7ed33feb981739a926f18e6318e9 https://github.com/tribe29/checkmk/commit/bf5b15993d2e7ed33feb981739a926f18… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: A .werks/11087 M cmk/ec/main.py Log Message: ----------- 11087 FIX mkeventd_status: Check was showing wrong list of active rule limits The check was showing "rule event limit active" for rules which have not reached the rule event limit. This happened for rules that had a rule individual limit configured because the check was only respecting the global rule event limits. Change-Id: I987a14425b089a8554db9a2b778c2699aca4e513 Commit: 74719d97f0fd6da5bfe862834fb2ac18184adc43 https://github.com/tribe29/checkmk/commit/74719d97f0fd6da5bfe862834fb2ac181… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: A .werks/11250 M cmk/ec/main.py M tests/unit/cmk/ec/test_ec_status.py Log Message: ----------- 11250 FIX mkeventd_status: Check was showing wrong list of active host limits The check was showing "host event limit active" for hosts which have not reached the host event limit. This happened for hosts that had a host individual limit configured (Using the ruleset "Host event limit") because the check was only respecting the global host event limits. Change-Id: I7359542936ecc2305897664c571a5bc4b8474131 Commit: 7bd46b167c8ce09b5cc79995a4622dbe5f35713a https://github.com/tribe29/checkmk/commit/7bd46b167c8ce09b5cc79995a4622dbe5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-07-10 (Fri, 10 Jul 2020) Changed paths: M cmk/ec/main.py Log Message: ----------- Fix core config cache update When the core config loading was not triggered by get_canonical_name and get_config_for_host was called first, the cache was not populated and the EC was working with the default config instead of the config that is currently active in the core. This could make the EC miss e.g. host individual limit rules. Change-Id: I00a7b47947cdc39182990b48b699b06c02266292 Compare: https://github.com/tribe29/checkmk/compare/2b1866e72aa4...7bd46b167c8c