[checkmk-commits] [tribe29/checkmk] 97e9c3: core config: consistent duplicate services warning

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 97e9c35285bba51771793e6a845b50c6f411a818 https://github.com/tribe29/checkmk/commit/97e9c35285bba51771793e6a845b50c6f… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-09-17 (Thu, 17 Sep 2020) Changed paths: M cmk/base/core_config.py M cmk/base/core_nagios.py Log Message: ----------- core config: consistent duplicate services warning Generate a consistent duplicate service warning. Note that the 'remove_duplicates' flag does *not* guarantee the uniqueness of service descriptions! CMK-5393 Change-Id: I71a0d28c971ae21f4f1b7f1580102ce16501d107 Commit: b8fc776dab3177821b612cf3036dd7d4167c3c28 https://github.com/tribe29/checkmk/commit/b8fc776dab3177821b612cf3036dd7d41… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-09-17 (Thu, 17 Sep 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/check_table.py M cmk/base/checkers/_checkers.py M cmk/base/checkers/snmp.py M cmk/base/checking.py M cmk/base/core_nagios.py M cmk/base/discovery.py M tests/unit/cmk/base/checkers/test_data_sources.py Log Message: ----------- check_table: remove deduplication Note that the removed code is already different from the code of the latest released version. In verison 1.6 the 'remove_duplicate' flag did *not* guarantee a unique service description, it only removed duplicates if one service corresponded to an SNMP- and one to an TCP-plugin. This distiction, however, can no longer be made in the new API. Thus we drop duplicate removal *at that point* completely. When writing the core configuration duplicate services will be dropped, and a warning is generated. CMK-5393 Change-Id: I5bc6e5137b11c7cb6cf4a94591ababb0051f58b4 Commit: cc8845e031724de1cef2a155f0e1919008f1cbd6 https://github.com/tribe29/checkmk/commit/cc8845e031724de1cef2a155f0e191900… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-09-17 (Thu, 17 Sep 2020) Changed paths: M cmk/base/check_table.py M tests/unit/cmk/base/test_check_table.py Log Message: ----------- make check_table a proper object I Change-Id: Ie114cd4bc6daa4312a47576778d9ddd219698f4c Commit: 7285ccd87233a2cece2de9a41d1edb5f5c1f171c https://github.com/tribe29/checkmk/commit/7285ccd87233a2cece2de9a41d1edb5f5… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-09-17 (Thu, 17 Sep 2020) Changed paths: M cmk/base/check_table.py Log Message: ----------- make check_table a proper object II * Remove caching from object * Make it inherit from CheckTable (Dict[ServiceID, Service]) * rename get to __init__ Change-Id: I517bc0e38b19a3e6716c6ab65f9e784b9f2c0212 Compare: https://github.com/tribe29/checkmk/compare/e71bf2220e99...7285ccd87233