[checkmk-commits] [tribe29/checkmk] 0b8b44: Fix TypeError for missing IPMI creds

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 0b8b444f1e8cae7e33597015fc9ec40919bdf859 https://github.com/tribe29/checkmk/commit/0b8b444f1e8cae7e33597015fc9ec4091… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-01 (Wed, 01 Apr 2020) Changed paths: M cmk/base/data_sources/ipmi.py M tests-py3/unit/cmk/base/data_sources/test_ipmi_management_board_data_source.py Log Message: ----------- Fix TypeError for missing IPMI creds Missing credentials raise TypeError: 'NoneType' object has no attribute '__getitem__' This patch turns this low level exception into a more user-friendly one. CMK-4143 Change-Id: Ifd720de350dc80b40a79bb721f911cf1e62f1229 Commit: e4fbcd0840a59c248c11be827ab0b049cca47a8d https://github.com/tribe29/checkmk/commit/e4fbcd0840a59c248c11be827ab0b049c… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-01 (Wed, 01 Apr 2020) Changed paths: M cmk/base/data_sources/ipmi.py M tests-py3/unit/cmk/base/data_sources/test_ipmi_management_board_data_source.py Log Message: ----------- Fix encoding problems for IPMI In some case, the parser `IPMI._parse_sensor_reading()` returns str and bytes where only bytes are expected. This results in the error [mgmt_ipmi] Fetching inventory information via UDP fro m 10.3.2.23:623 [mgmt_ipmi] ERROR: sequence item 1: expected a bytes-like object, str found ERROR [mgmt_ipmi]: sequence item 1: expected a bytes-like object, str found(?) and fail to return any IPMI data. This patch uses `six` to safely convert str to bytes. CMK-4143 Change-Id: If21aad1304fff72e9904ab4466e49f6fe692b9f1 Commit: fa056eeba55e3351a14f441d51d1aa6c0a5cc1e7 https://github.com/tribe29/checkmk/commit/fa056eeba55e3351a14f441d51d1aa6c0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-04-01 (Wed, 01 Apr 2020) Changed paths: M cmk/gui/plugins/metrics/artwork.py Log Message: ----------- Extract min/max value computation based on curves Change-Id: I25ef6465c3befec8da9a6f4db7c8332818212c42 Commit: 6f92cc5d397b35a69f743718236c3c2f36966bff https://github.com/tribe29/checkmk/commit/6f92cc5d397b35a69f743718236c3c2f3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-04-01 (Wed, 01 Apr 2020) Changed paths: M cmk/gui/plugins/metrics/artwork.py Log Message: ----------- Fix access to undefined variable Pylint and mypy were not able to find this issue. Wtf? Change-Id: Ifd2e00c21dc6ce370070497dea14cf6e404f08fd Commit: c49d7939cbe5c9d5b07337aacdf434685a759833 https://github.com/tribe29/checkmk/commit/c49d7939cbe5c9d5b07337aacdf434685… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-04-01 (Wed, 01 Apr 2020) Changed paths: M cmk/ec/main.py Log Message: ----------- Fix applying master config to slave EC config Change-Id: I1fa103c6ddbab79c1b762aa263230ac9e1cbf674 Commit: bda8b495a93382ee1c4b5f73b71ad1e59ff76ce8 https://github.com/tribe29/checkmk/commit/bda8b495a93382ee1c4b5f73b71ad1e59… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-04-01 (Wed, 01 Apr 2020) Changed paths: M cmk/gui/plugins/metrics/check_mk.py Log Message: ----------- Cleanup multiple duplicate metric definitions Change-Id: I5b4a3c5f7c66d3a8d068708fe7c948510c475356 Commit: 95500607c4dfa8376cbdfcc9ce8217b91cd8c5ef https://github.com/tribe29/checkmk/commit/95500607c4dfa8376cbdfcc9ce8217b91… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-04-01 (Wed, 01 Apr 2020) Changed paths: M cmk/gui/plugins/views/perfometers/check_mk.py Log Message: ----------- Cleanup multiple duplicate perfometer definitions Change-Id: I352ad5d6c8dceb54d3cef99bc66263bcfebef0aa Compare: https://github.com/tribe29/checkmk/compare/607b46fc926e...95500607c4df