[checkmk-commits] 3087 FIX fixed very rare crash in active checks

Module: check_mk Branch: master Commit: 7313a5c7bb24b17f631cd19fbf6a24c296a31abc URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7313a5c7bb24b1… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Mon Mar 7 14:37:19 2016 +0100 3087 FIX fixed very rare crash in active checks The error caused active check to go into warning state with output "expected a character buffer object" --- .werks/3087 | 11 +++++++++++ ChangeLog | 1 + modules/automation.py | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/3087 b/.werks/3087 new file mode 100644 index 0000000..7062290 --- /dev/null +++ b/.werks/3087 @@ -0,0 +1,11 @@ +Title: fixed very rare crash in active checks +Level: 1 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.2.9i1 +Date: 1457357683 + +The error caused active check to go into warning state with output "expected a character buffer +object" diff --git a/ChangeLog b/ChangeLog index d9afd1b..ed12996 100644 --- a/ChangeLog +++ b/ChangeLog @@ -57,6 +57,7 @@ * 3255 FIX: apc_inrow_temp: fixed wrong discovery handling of available sensors * 3256 FIX: blade_bx_powerfan: fixed wrong levels handling and minor cleanup * 3258 FIX: dell_idrac_disks: fixed disk and component status handling + * 3087 FIX: fixed very rare crash in active checks... Multisite: * 3187 notification view: new filter for log command via regex diff --git a/modules/automation.py b/modules/automation.py index 490a372..adaedb0 100644 --- a/modules/automation.py +++ b/modules/automation.py @@ -1306,7 +1306,7 @@ def replace_core_macros(hostname, commandline): macros = get_basic_host_macros_from_attributes(hostname, get_host_attributes(hostname)) load_resource_file(macros) for varname, value in macros.items(): - commandline = commandline.replace(varname, value) + commandline = commandline.replace(varname, str(value)) return commandline