[checkmk-commits] [tribe29/checkmk] 660b7e: Do not use the magic method __fspath__ directly.

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 660b7e5c427517d4987b3ccf686fb25ca4316438 https://github.com/tribe29/checkmk/commit/660b7e5c427517d4987b3ccf686fb25ca… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2019-11-15 (Fri, 15 Nov 2019) Changed paths: M agents/windows/msibuild/msi-update M tests/unit/agents/windows/msibuild/test_msi_update.py Log Message: ----------- Do not use the magic method __fspath__ directly. Magic methods are, well, magic, so they should normally not be called directly. The official Python 3 way for foo.__fspath__() is os.fspath(foo) Alas, Python 2 doesn't have os.fspath(), but in our case we are lucky: If we know that foo is a (Pure)Path, we can simply use str(foo), which is the equivalent for Python 2 *and* 3. (Note the different return types!) Change-Id: I5090187e0bb1a18143d18a8d4aae8d814dc06f10 Commit: 78dca30376832df2c58323c2d6b994eed95e9241 https://github.com/tribe29/checkmk/commit/78dca30376832df2c58323c2d6b994eed… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-11-15 (Fri, 15 Nov 2019) Changed paths: M cmk/special_agents/agent_elasticsearch.py M cmk/special_agents/agent_graylog.py M cmk/special_agents/agent_jenkins.py M cmk/special_agents/agent_splunk.py M cmk/special_agents/agent_vsphere.py M tests/unit/agents/special/test_sa_vsphere.py Log Message: ----------- special agents: unify and fix argv handling The function 'parse_arguments' will now be passed 'sys.argv[1:]' in the default case. Also some cases have been fixed where an explicitly passed 'argv' argument had not been considered. Change-Id: I46d738dccbe35c17d4153169126c58a1066c0c11 Commit: 28778ad8012bffab1aa97beddc3c3e9edd84fbcf https://github.com/tribe29/checkmk/commit/28778ad8012bffab1aa97beddc3c3e9ed… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-11-15 (Fri, 15 Nov 2019) Changed paths: M cmk/special_agents/agent_kubernetes.py A tests/unit/agents/special/test_special_agent_args.py Log Message: ----------- special agents: ensure consistent argument parsing The added test ensures that special agents in cmk/special_agents * use argparse * have a function called parse_arguments * that function returns an argparse.Namespace * accepts '--debug' Change-Id: Ic592185298b9e292a85c0843cef0a556a99a5f5d Commit: 354c450ea4ad1793b0507e4c3c6445d7b808b365 https://github.com/tribe29/checkmk/commit/354c450ea4ad1793b0507e4c3c6445d7b… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2019-11-15 (Fri, 15 Nov 2019) Changed paths: A .werks/10198 Log Message: ----------- 10198 FIX Windows Agent can be configured to use also non-WMI API to get data about running processes Previously the Bakery could not set "use_wmi" option to "no" (false) in the Windows Agent's configuration file. This error force the Agent to use only WMI API to get information about running processes. Now the error has been fixed and the Bakery generates the configuration file for the Windows Agent correctly Change-Id: I0d50a6f44c8e24f3730335d54b70de47ac23f7ff Commit: a1bbe93bf6b72b414efca27db4875ed6cc7ba896 https://github.com/tribe29/checkmk/commit/a1bbe93bf6b72b414efca27db4875ed6c… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2019-11-15 (Fri, 15 Nov 2019) Changed paths: M cmk/special_agents/utils.py Log Message: ----------- special_agents/utils: make _NullContext falsey Change-Id: Ia302578b063b69957da8e3f2159fcff73da820f2 Compare: https://github.com/tribe29/checkmk/compare/50129d4735bb...a1bbe93bf6b7