[checkmk-commits] 3650 FIX Fixed bash versionitis, unbreaking cached check results.

Module: check_mk Branch: master Commit: d0fd001c7384e751fad24fce0daa6e0f6114c8d5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d0fd001c7384e7… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Tue Oct 18 15:29:59 2016 +0200 3650 FIX Fixed bash versionitis, unbreaking cached check results. Our shebang lines in scripts explicitly state which bash they want, and the bash instances we start from the script should better use the exact same version. If there is a version mismatch, lots of funny things can happen, the most prominent being that caching check results doesn't work anymore (e.g. when using MRPE). This is caused by the bash fixes for the Shellshock vulnerability which change (among other things) how functions are exported to sub-shells. The consequence is that a pre-Shellshock bash doesn't see the functions exported by a post-Shellshock bash, and vice versa. This setup can happen when the shebang and the user's PATH have different ideas about which bash to use. To fix this, we use the same absolute path for starting the bash sub-processes as the one stated in the corresponding shebang. --- .werks/3650 | 24 ++++++++++++++++++++++++ ChangeLog | 1 + 2 files changed, 25 insertions(+) diff --git a/.werks/3650 b/.werks/3650 new file mode 100644 index 0000000..793a667 --- /dev/null +++ b/.werks/3650 @@ -0,0 +1,24 @@ +Title: Fixed bash versionitis, unbreaking cached check results. +Level: 1 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.4.0i2 +Date: 1476797337 + +Our shebang lines in scripts explicitly state which bash they want, and the +bash instances we start from the script should better use the exact same +version. If there is a version mismatch, lots of funny things can happen, +the most prominent being that caching check results doesn't work anymore +(e.g. when using MRPE). This is caused by the bash fixes for the +Shellshock vulnerability which change (among other things) how functions are +exported to sub-shells. The consequence is that a pre-Shellshock bash +doesn't see the functions exported by a post-Shellshock bash, and vice +versa. This setup can happen when the shebang and the user's PATH have +different ideas about which bash to use. + +To fix this, we use the same absolute path for starting the bash +sub-processes as the one stated in the corresponding shebang. + + diff --git a/ChangeLog b/ChangeLog index 73cba57..7fdf705 100644 --- a/ChangeLog +++ b/ChangeLog @@ -29,6 +29,7 @@ * 3964 FIX: df_zos: Fixed not working filesystemcheck for IBM z/OS... * 3826 FIX: netapp_api_connection: now removes duplicate warning messages * 3827 FIX: windows agent: fixed 3 bugs which broke the skype section + * 3650 FIX: Fixed bash versionitis, unbreaking cached check results.... Multisite: * 3959 Two new filters for the comment view: author and comment text field