[checkmk-commits] [tribe29/checkmk] 88474a: Program data source: get rid of one local variable

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 88474a57af78d160b4cdc5a554ddb22a470cc410 https://github.com/tribe29/checkmk/commit/88474a57af78d160b4cdc5a554ddb22a4… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-16 (Thu, 16 Apr 2020) Changed paths: M cmk/base/data_sources/programs.py Log Message: ----------- Program data source: get rid of one local variable This patch removes the local variable `exitstatus`. - The exitstatus local variable is not necessary. - It could cause a NameError exception if an exception was raised before it is set. - The error handling may now be flattened. - We also reduce the scope of `exepath`. - The business logic is no more split into two parts (in the try/except and at the end of the function). CMK-4218 Change-Id: Ib64aae111e13fafba4ea98160a7d0d8f5df5324c Commit: 4445bf67461a7e7b98739d4fe15d594030447c28 https://github.com/tribe29/checkmk/commit/4445bf67461a7e7b98739d4fe15d59403… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-16 (Thu, 16 Apr 2020) Changed paths: M cmk/base/data_sources/programs.py Log Message: ----------- ProgramDataFetcher class CMK-4218 Change-Id: I4d0bdfdc43abbd4192b425d5fd419f9b55f80012 Commit: ad81457f31f55cfb9e27b93de8b41f7f3b21fb09 https://github.com/tribe29/checkmk/commit/ad81457f31f55cfb9e27b93de8b41f7f3… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-16 (Thu, 16 Apr 2020) Changed paths: M cmk/base/data_sources/abstract.py M cmk/base/data_sources/ipmi.py M cmk/base/data_sources/piggyback.py M cmk/base/data_sources/programs.py M cmk/base/data_sources/tcp.py Log Message: ----------- Make data fetcher interface explicit Extract interface for the fetchers. CMK-4218 Change-Id: I56803f2f90e52ad3a7b4af53a1769054298cf92b Commit: ae21d7c741872eaf47f05b612d421cdd6bf7bec6 https://github.com/tribe29/checkmk/commit/ae21d7c741872eaf47f05b612d421cdd6… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-04-16 (Thu, 16 Apr 2020) Changed paths: M cmk/base/data_sources/ipmi.py M cmk/base/data_sources/piggyback.py M cmk/base/data_sources/tcp.py Log Message: ----------- Improve error handling in data sources CMK-4218 Change-Id: I1d90880b97fb2a40e49ca2625923fc29a05e77e3 Compare: https://github.com/tribe29/checkmk/compare/d1224f946df9...ae21d7c74187