[checkmk-commits] [tribe29/checkmk] c78d04: Improve GUI unit test performance

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c78d04a9ae7572a417e167185ded741c19f602ee https://github.com/tribe29/checkmk/commit/c78d04a9ae7572a417e167185ded741c1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- Improve GUI unit test performance Instead of building the same app over and over for each unit test, we now use the once built WSGI app for all unit tests that need the wsgi_app. Previous time needed: 230 sec. Now: 70 sec :-) Change-Id: I16d80d90c7a42ce682cf2b6c319673f40fddedc9 Commit: d7144faf94cbf7ae615ef5d029888f6f888e748a https://github.com/tribe29/checkmk/commit/d7144faf94cbf7ae615ef5d029888f6f8… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M cmk/gui/plugins/visuals/wato.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py Log Message: ----------- Improve GUI tests by mocking livestatus Some unit tests accidentally tried to execute livestatus queries: * Report rendering tests render views, which tried to get data from livestatus * Rendering and processing filters in tests We now use the generic livestatus mock to get get real data to show. Only the WATO folder filter needed to be mocked, because it issues a query with Stats header that is not understood by the livestatus mock at the moment. Bringing down these tests from 10 sec to 0.x sec. Change-Id: Icd7970e08cd269e86622c8bf5dfd7ff8b0dd6459 Commit: 7baee85ce699c82b01d6bffce4281200db2ab64b https://github.com/tribe29/checkmk/commit/7baee85ce699c82b01d6bffce4281200d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/conftest.py M tests/unit/livestatus/test_livestatus_unit.py Log Message: ----------- Add generic fixture to prevent accidental livestatus connects Some unit tests were creating livestatus connections by accident which resulted in long running tests that wait for a connect timeout. This new fixture is executed by every test and will raise an exception in case a test tried to connect to livestatus. Change-Id: I25c750a66e7ff8cf22b16ccbd20de411ef68f11f Commit: 4b0b8c26eb692f15e8437dbc443bb27457500e0d https://github.com/tribe29/checkmk/commit/4b0b8c26eb692f15e8437dbc443bb2745… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-19 (Mon, 19 Oct 2020) Changed paths: M tests/unit/inventory/test_generic_legacy_conversion_inv.py Log Message: ----------- Fix false positive Change-Id: Iec17c712c960a879c964bde11796a1fbbec9a295 Compare: https://github.com/tribe29/checkmk/compare/469ffb0488b7...4b0b8c26eb69