[checkmk-commits] [tribe29/checkmk] 0264b6: PRO TIP: Migrate inventory plugins: prepare sectio...

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 0264b6acdef677ff7ae323a696ddbe17d41116fc https://github.com/tribe29/checkmk/commit/0264b6acdef677ff7ae323a696ddbe17d… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-08-06 (Fri, 06 Aug 2021) Changed paths: M checks/oracle_instance A cmk/base/plugins/agent_based/oracle_instance.py M tests/unit/checks/generictests/datasets/oracle_instance_regression.py M tests/unit/checks/test_oracle_instance.py Log Message: ----------- PRO TIP: Migrate inventory plugins: prepare section plugin In order to migrate an inventory plugin to the new API, it is best to first migrate the required section. While not strictly necessary, a dedicated section plugin decouples the inventory and check plugins. In this commit: * move the parse function ** rename "info" -> "string_table" (required) ** add a few type hints (optional) * register the section * add a comment to the legacy plugins (for less puzzlement) Change-Id: Idc4060f5f7f12371aa8baf1fbd8d0d76ad1d53fb Commit: 5e4ce184b132907753146e5ec301900436180f48 https://github.com/tribe29/checkmk/commit/5e4ce184b132907753146e5ec30190043… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-08-06 (Fri, 06 Aug 2021) Changed paths: M cmk/base/plugins/agent_based/oracle_instance.py M inventory/oracle_instance Log Message: ----------- oracle_instance: minor cleanups Change-Id: I9d610522d298694b387bb8a98d2fe96f3c7c1b13 Commit: e926cc58adb8297030fb03d61c7854a96311e7fb https://github.com/tribe29/checkmk/commit/e926cc58adb8297030fb03d61c7854a96… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2021-08-06 (Fri, 06 Aug 2021) Changed paths: M cmk/base/plugins/agent_based/oracle_instance.py R inventory/oracle_instance M tests/unit/cmk/base/plugins/agent_based/test_inv_oracle_instance.py Log Message: ----------- PRO TIP: Migrate inventory plugins In order to migrate an inventory plugin to the new API the following steps must be taken: * Move the file to the new location (or add the content to an existing file, as in this case). * Adjust the arguments of the inventory function (refer to the sphinx documentation or the doc-string of the `register.inventory_plugin` for details). * Reorganize the function to be a generator of TableRows. Note that the SID is the only `key_column`. If all of the key_columns of two TableRows contain the same values, the backend will assume they are in fact refering to the same 'thing', and merge them into the same row. This logic is used when computing the inventory history or merging information gathered from configured 'retention intervals'. Change-Id: Ic24e6b454430377b1626c3510842922e725f60c7 Compare: https://github.com/tribe29/checkmk/compare/636b5308d620...e926cc58adb8