[checkmk-commits] 6818 FIX netapp_api_volumes: Added forgotten 'operations/s' metrics

Module: check_mk Branch: master Commit: d3e2e1cfc353a39438c76dbdb85236cd093d32df URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d3e2e1cfc353a3… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Nov 27 15:36:43 2018 +0100 6818 FIX netapp_api_volumes: Added forgotten 'operations/s' metrics Change-Id: I9dc536cd00b641ef0c19d05a29cd848eec486cfc --- .werks/6818 | 10 ++++++++++ cmk/gui/plugins/metrics/check_mk.py | 11 +++++++++++ 2 files changed, 21 insertions(+) diff --git a/.werks/6818 b/.werks/6818 new file mode 100644 index 0000000..ef32eda --- /dev/null +++ b/.werks/6818 @@ -0,0 +1,10 @@ +Title: netapp_api_volumes: Added forgotten 'operations/s' metrics +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.6.0i1 +Date: 1543329287 +Class: fix + + diff --git a/cmk/gui/plugins/metrics/check_mk.py b/cmk/gui/plugins/metrics/check_mk.py index b97dd37..24d160c 100644 --- a/cmk/gui/plugins/metrics/check_mk.py +++ b/cmk/gui/plugins/metrics/check_mk.py @@ -3374,6 +3374,7 @@ for volume_info in ["NFS", "NFSv4", "NFSv4.1", "CIFS", "SAN", "FCP", "ISCSI"]: ("latency", "s"), ("ios", "1/s"), ("throughput", "bytes/s"), + ("ops", "1/s"), ]: volume = volume_info.lower().replace(".", "_") @@ -5403,6 +5404,8 @@ for protocol in ["nfs", "cifs", "san", "fcp", "iscsi", "nfsv4", "nfsv4_1"]: df_netapp_perfvarnames.append("%s_write_data" % protocol) df_netapp_perfvarnames.append("%s_read_latency" % protocol) df_netapp_perfvarnames.append("%s_write_latency" % protocol) + df_netapp_perfvarnames.append("%s_read_ops" % protocol) + df_netapp_perfvarnames.append("%s_write_ops" % protocol) # TODO: this special regex construct below, needs to be replaced by something managable # The current df_translation implementation is unable to automatically detect new parameters @@ -9278,6 +9281,14 @@ for what, text in [ ], } + graph_info["%s_ops" % what] = { + "title": _("%s latency") % text, + "metrics": [ + ("%s_read_ops" % what, "-area"), + ("%s_write_ops" % what, "area"), + ], + } + graph_info["harddrive_health_statistic"] = { "title": _("Harddrive health statistic"), "metrics": [